PaymentApp: Remove scope_url parameter from Get/SetManifest methods.

content/browser/payments/payment_app_context_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstddef>
 #include <string>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 49 matching lines @@
 
     payments::mojom::PaymentAppManifestPtr manifest =
         payments::mojom::PaymentAppManifest::New();
     manifest->icon = std::string("payment-app-icon");
     manifest->name = scope_url.spec();
     manifest->options.push_back(std::move(option));
 
     payments::mojom::PaymentAppManifestError error = payments::mojom::
         PaymentAppManifestError::MANIFEST_STORAGE_OPERATION_FAILED;
     bool called = false;
-    SetManifest(manager, scope_url.spec(), std::move(manifest),
+    SetManifest(manager, std::move(manifest),
                 base::Bind(&SetManifestCallback, &called, &error));
     ASSERT_TRUE(called);
 
     ASSERT_EQ(error, payments::mojom::PaymentAppManifestError::NONE);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PaymentAppContextTest);
 };
 
@@ skipping 12 matching lines @@
   }
 
   PaymentAppContext::Manifests manifests;
   bool called = false;
   GetAllManifests(base::Bind(&GetAllManifestsCallback, &called, &manifests));
   ASSERT_TRUE(called);
 
   ASSERT_EQ(manifests.size(), 3U);
   size_t i = 0;
   for (const auto& manifest : manifests) {
     EXPECT_EQ(manifest.second->icon.value(), "payment-app-icon");

[please use gerrit instead, 2016/12/20 17:25:17]

You seem to have reversed the "expected" and "actual" here. The expected should
be on the left. That way error messages look like this:

Expected "payment-app-icon", but found manifest.second->icon.value(), which is
"not-what-was-expected".

[zino, 2016/12/20 17:30:53]

Sure,

So, I made a CL for this. You are already a reviewer in the CL.
I'll rebase this CL after landing the test CL.

     EXPECT_EQ(manifest.second->name, kPaymentAppInfo[i++].scopeUrl);
     ASSERT_EQ(manifest.second->options.size(), 1U);
     EXPECT_EQ(manifest.second->options[0]->icon.value(), "payment-app-icon");
     EXPECT_EQ(manifest.second->options[0]->name, "Visa ****");
     EXPECT_EQ(manifest.second->options[0]->id, "payment-app-id");
     ASSERT_EQ(manifest.second->options[0]->enabled_methods.size(), 1U);
     EXPECT_EQ(manifest.second->options[0]->enabled_methods[0], "visa");
   }
 }
 
 }  // namespace content