Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2586143004: Blur immediately if an attribute change made an element unfocasable. (Closed)
Patch Set: Update comments and a function name Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 6 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 if (!parent || !parent->isSVGElement()) 911 if (!parent || !parent->isSVGElement())
912 return; 912 return;
913 913
914 toSVGElement(parent)->sendSVGLoadEventToSelfAndAncestorChainIfPossible(); 914 toSVGElement(parent)->sendSVGLoadEventToSelfAndAncestorChainIfPossible();
915 } 915 }
916 916
917 void SVGElement::attributeChanged(const QualifiedName& name, 917 void SVGElement::attributeChanged(const QualifiedName& name,
918 const AtomicString& oldValue, 918 const AtomicString& oldValue,
919 const AtomicString& newValue, 919 const AtomicString& newValue,
920 AttributeModificationReason) { 920 AttributeModificationReason) {
921 Element::attributeChanged(name, oldValue, newValue); 921 Element::attributeChanged(name, oldValue, newValue,
922 AttributeModificationReason::kDirectly);
922 923
923 if (name == HTMLNames::idAttr) 924 if (name == HTMLNames::idAttr)
924 rebuildAllIncomingReferences(); 925 rebuildAllIncomingReferences();
925 926
926 // Changes to the style attribute are processed lazily (see 927 // Changes to the style attribute are processed lazily (see
927 // Element::getAttribute() and related methods), so we don't want changes to 928 // Element::getAttribute() and related methods), so we don't want changes to
928 // the style attribute to result in extra work here. 929 // the style attribute to result in extra work here.
929 if (name == HTMLNames::styleAttr) 930 if (name == HTMLNames::styleAttr)
930 return; 931 return;
931 932
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 visitor->trace(m_className); 1287 visitor->trace(m_className);
1287 Element::trace(visitor); 1288 Element::trace(visitor);
1288 } 1289 }
1289 1290
1290 const AtomicString& SVGElement::eventParameterName() { 1291 const AtomicString& SVGElement::eventParameterName() {
1291 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt")); 1292 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
1292 return evtString; 1293 return evtString;
1293 } 1294 }
1294 1295
1295 } // namespace blink 1296 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698