Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(336)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/intl/OWNERS
Issue
2585903002
:
Ship Intl.DateTimeFormat.formatToParts() (Closed)
Patch Set: test/intl/OWNERS update
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/flag-definitions.h
test/intl/OWNERS
test/intl/date-format/date-format-to-parts.js
View unified diff
|
Download patch
« no previous file with comments
|
« src/flag-definitions.h
('k') |
test/intl/date-format/date-format-to-parts.js »
('j') |
test/intl/date-format/date-format-to-parts.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
cira@chromium.org
2 mnita@google.com
1 mnita@google.com
2
jshin@chromium.org
Dan Ehrenberg
2016/12/16 23:40:08
Could you separate this change into a separate pat
Could you separate this change into a separate patch?
jungshik at Google
2016/12/19 07:27:43
Dropped
Show quoted text
On 2016/12/16 23:40:08, Dan Ehrenberg wrote: > Could you separate this change into a separate patch?
Dropped
OLD
NEW
« no previous file with comments
|
« src/flag-definitions.h
('k') |
test/intl/date-format/date-format-to-parts.js »
('j') |
test/intl/date-format/date-format-to-parts.js »
('J')
Issue 2585903002: Ship Intl.DateTimeFormat.formatToParts() (Closed)
Created 4 years ago by jungshik at Google
Modified 4 years ago
Reviewers: Dan Ehrenberg, adamk
Base URL:
Comments: 4
This is Rietveld
408576698