Issue 25859006: Remove --pdf option as it can now be controlled by --config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25859006: Remove --pdf option as it can now be controlled by --config (Closed)

Created:
7 years, 2 months ago by djsollen

Modified:
7 years, 2 months ago

Reviewers:
borenet, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Remove --pdf option as it can now be controlled by --config Committed: http://code.google.com/p/skia/source/detail?r=11666

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	gm/gmmain.cpp	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

borenet

Will this cause an error if --nopdf is provided? If so, this will depend on ...

7 years, 2 months ago (2013-10-04 12:57:43 UTC) #2

borenet

On 2013/10/04 12:57:43, borenet wrote: > Will this cause an error if --nopdf is provided? ...

7 years, 2 months ago (2013-10-09 12:48:53 UTC) #3

bsalomon

On 2013/10/09 12:48:53, borenet wrote: > On 2013/10/04 12:57:43, borenet wrote: > > Will this ...

7 years, 2 months ago (2013-10-09 13:17:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/25859006/1

7 years, 2 months ago (2013-10-09 13:18:14 UTC) #5

Message was sent while issue was closed.

Change committed as 11666