Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2635)

Unified Diff: chrome/browser/ui/app_list/apps_model_builder.h

Issue 25859005: Elim ActivateAppListItem, ChromeAppListItem (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix static cast in AppModelBuilder, add AppType Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/apps_model_builder.h
diff --git a/chrome/browser/ui/app_list/apps_model_builder.h b/chrome/browser/ui/app_list/apps_model_builder.h
index 48628967079f3f421287c862c2c0af58623f14bd..f4b1deff6ff895d3ec9cdcc6fa1852214d899ce4 100644
--- a/chrome/browser/ui/app_list/apps_model_builder.h
+++ b/chrome/browser/ui/app_list/apps_model_builder.h
@@ -18,6 +18,10 @@ class ExtensionAppItem;
class ExtensionSet;
class Profile;
+namespace app_list {
+class AppListItemModel;
+}
+
namespace extensions {
class Extension;
class InstallTracker;
@@ -38,13 +42,13 @@ class AppsModelBuilder : public ui::ListModelObserver,
virtual ~AppsModelBuilder();
// Returns app instance with id |extension_id|.
- ExtensionAppItem* GetApp(const std::string& extension_id);
+ app_list::AppListItemModel* GetApp(const std::string& extension_id);
// Rebuilds the model with the given profile.
void SwitchProfile(Profile* profile);
private:
- typedef std::vector<ExtensionAppItem*> Apps;
+ typedef std::vector<ExtensionAppItem*> ExtensionApps;
// Overridden from extensions::InstallObserver:
virtual void OnBeginExtensionInstall(const std::string& extension_id,
@@ -71,7 +75,7 @@ class AppsModelBuilder : public ui::ListModelObserver,
virtual void OnShutdown() OVERRIDE;
// Adds apps in |extensions| to |apps|.
- void AddApps(const ExtensionSet* extensions, Apps* apps);
+ void AddApps(const ExtensionSet* extensions, ExtensionApps* apps);
jennyz 2013/10/03 20:40:27 Should this be renamed as AddExtensionApps?
// Populates the model with apps.
void PopulateApps();
@@ -97,7 +101,11 @@ class AppsModelBuilder : public ui::ListModelObserver,
void UpdateHighlight();
// Returns app instance at given |index|.
- ExtensionAppItem* GetAppAt(size_t index);
+ app_list::AppListItemModel* GetAppAt(size_t index);
+
+ // Returns the ExtensionAppItem at |index| or NULL if the item is not an
+ // exension app.
+ ExtensionAppItem* GetExtensionAppAt(size_t index);
// ui::ListModelObserver overrides:
virtual void ListItemsAdded(size_t start, size_t count) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698