Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2585723004: Revert of Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity (Closed)

Created:
4 years ago by boliu
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity (patchset #1 id:1 of https://codereview.chromium.org/2586603002/ ) Reason for revert: Not sure how this passed cq. But.. E 73.899s Main Unrecognized error occurred. Traceback (most recent call last): File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 879, in main return RunTestsCommand(args) File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 665, in RunTestsCommand return RunTestsInPlatformMode(args) File "/b/swarm_slave/w/irpT6Ugr/build/android/test_runner.py", line 774, in RunTestsInPlatformMode raw_results = test_run.RunTests() File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/local/device/local_device_test_run.py", line 65, in RunTests tests = self._GetTests() File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/local/device/local_device_instrumentation_test_run.py", line 177, in _GetTests return self._test_instance.GetTests() File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/instrumentation/instrumentation_test_instance.py", line 751, in GetTests self._excluded_annotations) File "/b/swarm_slave/w/irpT6Ugr/build/android/pylib/instrumentation/instrumentation_test_instance.py", line 282, in FilterTests raise MissingSizeAnnotationError(GetTestName(t)) MissingSizeAnnotationError: org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest#testSingleRunningChromeTabbedActivity: Test method is missing required size annotation. Add one of: @LargeTest, @PerfTest, @Manual, @FlakyTest, @DisabledTest, @MediumTest, @Smoke, @SmallTest, @IntegrationTest, @EnormousTest Original issue's description: > Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity > > BUG=671268 > TBR=tedchoc@chromium.org > > Committed: https://crrev.com/289f5bc28ed08151664f28e085ec6d2ed26cb3c6 > Cr-Commit-Position: refs/heads/master@{#439231} TBR=rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoNotificationServiceTest.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
boliu
Created Revert of Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity
4 years ago (2016-12-17 02:22:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585723004/1
4 years ago (2016-12-17 02:22:47 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoNotificationServiceTest.java: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-17 02:23:44 UTC) #5
Ken Rockot(use gerrit already)
4 years ago (2016-12-17 02:28:22 UTC) #7
Message was sent while issue was closed. 
Rjkroege fixed it. Sorry for the trouble

On Dec 16, 2016 6:23 PM, "commit-bot@chromium.org via
codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

> Failed to apply patch for
> chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java:
> While running git apply --index -p1;
> error: patch failed:
> chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java:56
> error:
> chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java:
> patch does not apply
>
> Patch:
> chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java
> Index:
> chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java
> diff --git
> a/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java
> b/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java
> index
> e57b1d4427f217264c55d1395cac5e356a9d9afa..145ff65c341a95959c899f5f3c30c3
> 4854049a19
> 100644
> ---
> a/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java
> +++
> b/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/
> IncognitoNotificationServiceTest.java
> @@ -12,6 +12,7 @@
>
> import org.chromium.base.ThreadUtils;
> import org.chromium.base.library_loader.LibraryLoader;
> +import org.chromium.base.test.util.DisabledTest;
> import org.chromium.base.test.util.Feature;
> import org.chromium.base.test.util.RetryOnFailure;
> import org.chromium.chrome.browser.TabState;
> @@ -56,8 +57,10 @@
>
> }
>
> + // Flaky, see crbug.com/671268
> // @Feature("Incognito")
> // @MediumTest
> + @DisabledTest
> public void testSingleRunningChromeTabbedActivity()
> throws InterruptedException, CanceledException {
> startMainActivityOnBlankPage();
>
>
> https://codereview.chromium.org/2585723004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698