Adding apprtc and downloading of google appengine sdk to webrtc.DEPS.

Adding apprtc and downloading of google appengine sdk to webrtc.DEPS.

R=kjellander@chromium.org
BUG=303021
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227910

[kjellander_chromium, 2013-10-04 12:38:33]

Have you tested this on Linux, Mac and Windows?

https://codereview.chromium.org/25857002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/25857002/diff/1/DEPS#newcode12
DEPS:12: "https://webrtc.googlecode.com/svn/trunk/samples/js",
https://webrtc.googlecode.com/svn/trunk/samples/js/apprtc should make more sense
here, right?

[phoglund1, 2013-10-04 12:52:05]

Will test on mac and win as well.

https://codereview.chromium.org/25857002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/25857002/diff/1/DEPS#newcode12
DEPS:12: "https://webrtc.googlecode.com/svn/trunk/samples/js",
On 2013/10/04 12:38:33, Henrik Kjellander wrote:
> https://webrtc.googlecode.com/svn/trunk/samples/js/apprtc should make more
sense
> here, right?
I thought so too, but it turns out apprtc needs stuff from js/base, so I need to
check the parent level out.

[kjellander_chromium, 2013-10-04 12:56:41]

lgtm, assuming nothing pops up during your Mac and Win testing.

[phoglund_chromium, 2013-10-04 13:44:25]

On 2013/10/04 12:56:41, Henrik Kjellander wrote:
> lgtm, assuming nothing pops up during your Mac and Win testing.

Yeah, turns out we are 1) running an ancient version of python on win which does
not support zipfile with..as constructs, and 2) hooks are apparently not
guaranteed to run in sequence, so the second step will fail at least the first
time because the zip file hasn't been fully downloaded yet. I'll fix that next
week.

[kjellander_chromium, 2013-10-10 09:02:22]

Additional comments

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py
File download_appengine_sdk.py (right):

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py#...
download_appengine_sdk.py:21: subprocess.check_call(cmd)
Does this work on windows without providing sys.executable?

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py#...
download_appengine_sdk.py:39: _Unzip(os.path.join(webrtc_deps_path,
'google-appengine.zip'))
Hmm, is it the right thing to do to exact this into a source controlled folder? 
I was thinking more of something like ~/google_appengine (if it doesn't already
exist)

[phoglund_chromium, 2013-10-10 09:38:15]

Alright, this works now. PTAL

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py
File download_appengine_sdk.py (right):

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py#...
download_appengine_sdk.py:21: subprocess.check_call(cmd)
On 2013/10/10 09:02:23, Henrik Kjellander wrote:
> Does this work on windows without providing sys.executable?
Nope, and if I do that I will have to locate depot_tools on the system to find
the python file since I can't do PATH lookup. Fortunately I can call the .bat
file on Win instead, which is in the PATH.

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py#...
download_appengine_sdk.py:39: _Unzip(os.path.join(webrtc_deps_path,
'google-appengine.zip'))
On 2013/10/10 09:02:23, Henrik Kjellander wrote:
> Hmm, is it the right thing to do to exact this into a source controlled
folder? 
> I was thinking more of something like ~/google_appengine (if it doesn't
already
> exist)
It extracts into the level above the source controlled folders, e.g. where the
.gclient file is. I think that's cleaner than writing into a user's home dir.

[kjellander_chromium, 2013-10-10 09:53:03]

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py
File download_appengine_sdk.py (right):

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py#...
download_appengine_sdk.py:21: subprocess.check_call(cmd)
On 2013/10/10 09:38:16, phoglund wrote:
> On 2013/10/10 09:02:23, Henrik Kjellander wrote:
> > Does this work on windows without providing sys.executable?
> Nope, and if I do that I will have to locate depot_tools on the system to find
> the python file since I can't do PATH lookup. Fortunately I can call the .bat
> file on Win instead, which is in the PATH.

SG, great!

https://codereview.chromium.org/25857002/diff/9001/download_appengine_sdk.py#...
download_appengine_sdk.py:39: _Unzip(os.path.join(webrtc_deps_path,
'google-appengine.zip'))
On 2013/10/10 09:38:16, phoglund wrote:
> On 2013/10/10 09:02:23, Henrik Kjellander wrote:
> > Hmm, is it the right thing to do to exact this into a source controlled
> folder? 
> > I was thinking more of something like ~/google_appengine (if it doesn't
> already
> > exist)
> It extracts into the level above the source controlled folders, e.g. where the
> .gclient file is. I think that's cleaner than writing into a user's home dir.

That sounds like the best approach, yes.

https://codereview.chromium.org/25857002/diff/15001/download_appengine_sdk.py
File download_appengine_sdk.py (right):

https://codereview.chromium.org/25857002/diff/15001/download_appengine_sdk.py...
download_appengine_sdk.py:52: _DeleteOldAppEngineDir()
I think this will slow us down too much to run for each runhooks step. Please
implement logic for only removing the previous dir when needed.

[phoglund_chromium, 2013-10-10 10:07:33]

PTAL

[kjellander_chromium, 2013-10-10 10:09:52]

LGTM

Let's hope the download of the zip file never ever fails, since we can't handle
that case.

[phoglund_chromium, 2013-10-10 10:42:08]

Committed patchset #5 manually as r227910 (presubmit successful).