Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 258563005: Use GenericEventQueue class in MediaController (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, ojan
Visibility:
Public.

Description

Use GenericEventQueue class in MediaController Use GenericEventQueue class in MediaController to make the event dispatching code simpler. R=esprehn@chromium.org, tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M Source/core/html/MediaController.h View 4 chunks +2 lines, -6 lines 0 comments Download
M Source/core/html/MediaController.cpp View 3 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 8 months ago (2014-04-24 21:15:59 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-24 21:18:40 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-24 22:30:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/258563005/1
6 years, 8 months ago (2014-04-24 22:31:26 UTC) #4
commit-bot: I haz the power
Change committed as 172566
6 years, 8 months ago (2014-04-24 23:52:10 UTC) #5
philipj_slow
I think was an improvement, but just as an FYI the spec says "The task ...
6 years, 8 months ago (2014-04-25 12:16:04 UTC) #6
acolwell GONE FROM CHROMIUM
6 years, 8 months ago (2014-04-25 15:04:44 UTC) #7
Message was sent while issue was closed.
On 2014/04/25 12:16:04, philipj wrote:
> I think was an improvement, but just as an FYI the spec says "The task source
> for the tasks listed in this section is the DOM manipulation task source"
which
> isn't what this code did before or after this change. I wrote a test to expose
> the problem which should eventually reach Blink:
> https://critic.hoppipolla.co.uk/r/1383

Hmm.. It seems like we need to find a place to represent the "task source" so we
can fix this and the other media code to conform to this requirement.

Powered by Google App Engine
This is Rietveld 408576698