[SPInvaldation] Update subtree paint properties when a layout subtree is inserted

third_party/WebKit/Source/core/layout/LayoutObject.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1639 matching lines @@
   // debugging output
   virtual LayoutRect debugRect() const;
 
   // Painters can use const methods only, except for these explicitly declared
   // methods.
   class MutableForPainting {
    public:
     // Convenience mutator that clears paint invalidation flags and this object
     // and its descendants' needs-paint-property-update flags.
     void clearPaintFlags() {
+      DCHECK_EQ(m_layoutObject.document().lifecycle().state(),
+                DocumentLifecycle::InPrePaint);
       m_layoutObject.clearPaintInvalidationFlags();
-      m_layoutObject.clearNeedsPaintPropertyUpdate();
-      m_layoutObject.clearDescendantNeedsPaintPropertyUpdate();
+      m_layoutObject.m_bitfields.setNeedsPaintPropertyUpdate(false);
+      m_layoutObject.m_bitfields.setSubtreeNeedsPaintPropertyUpdate(false);
+      m_layoutObject.m_bitfields.setDescendantNeedsPaintPropertyUpdate(false);
     }
     void setShouldDoFullPaintInvalidation(PaintInvalidationReason reason) {
       m_layoutObject.setShouldDoFullPaintInvalidation(reason);
     }
     void setBackgroundChangedSinceLastPaintInvalidation() {
       m_layoutObject.setBackgroundChangedSinceLastPaintInvalidation();
     }
     void ensureIsReadyForPaintInvalidation() {
       m_layoutObject.ensureIsReadyForPaintInvalidation();
     }
@@ skipping 16 matching lines @@
     }
     void setPreviousBackgroundObscured(bool b) {
       m_layoutObject.setPreviousBackgroundObscured(b);
     }
     void clearPreviousVisualRects() {
       m_layoutObject.clearPreviousVisualRects();
     }
     void setNeedsPaintPropertyUpdate() {
       m_layoutObject.setNeedsPaintPropertyUpdate();
     }
+#if DCHECK_IS_ON()
+    // Same as setNeedsPaintPropertyUpdate() but does not mark ancestors as
+    // having a descendant needing a paint property update.
+    void setOnlyThisNeedsPaintPropertyUpdateForTesting() {
+      m_layoutObject.m_bitfields.setNeedsPaintPropertyUpdate(true);
+    }
+    void clearNeedsPaintPropertyUpdateForTesting() {
+      m_layoutObject.m_bitfields.setNeedsPaintPropertyUpdate(false);
+    }
+#endif
 
    protected:
     friend class PaintPropertyTreeBuilder;
     // The following two functions can be called from PaintPropertyTreeBuilder
     // only.
     ObjectPaintProperties& ensurePaintProperties() {
       return m_layoutObject.ensurePaintProperties();
     }
     ObjectPaintProperties* paintProperties() {
       return const_cast<ObjectPaintProperties*>(
@@ skipping 12 matching lines @@
 
   // Paint properties (see: |ObjectPaintProperties|) are built from an object's
   // state (location, transform, etc) as well as properties from ancestors.
   // When these inputs change, setNeedsPaintPropertyUpdate will cause a property
   // tree update during the next document lifecycle update.
   //
   // In addition to tracking if an object needs its own paint properties
   // updated, setNeedsPaintPropertyUpdate marks all ancestors as having a
   // descendant needing a paint property update too.
   void setNeedsPaintPropertyUpdate();
-#if DCHECK_IS_ON()
-  // Same as setNeedsPaintPropertyUpdate() but does not mark ancestors as
-  // having a descendant needing a paint property update.
-  void setOnlyThisNeedsPaintPropertyUpdateForTesting() {
-    m_bitfields.setNeedsPaintPropertyUpdate(true);
-  }
-#endif
   bool needsPaintPropertyUpdate() const {
     return m_bitfields.needsPaintPropertyUpdate();
   }
-  void clearNeedsPaintPropertyUpdate() {
-    DCHECK_EQ(document().lifecycle().state(), DocumentLifecycle::InPrePaint);
-    m_bitfields.setNeedsPaintPropertyUpdate(false);
+  void setSubtreeNeedsPaintPropertyUpdate() {
+    m_bitfields.setSubtreeNeedsPaintPropertyUpdate(true);
+    m_bitfields.setNeedsPaintPropertyUpdate(true);
+  }
+  bool subtreeNeedsPaintPropertyUpdate() const {
+    return m_bitfields.subtreeNeedsPaintPropertyUpdate();
   }
   bool descendantNeedsPaintPropertyUpdate() const {
     return m_bitfields.descendantNeedsPaintPropertyUpdate();
   }
-  void clearDescendantNeedsPaintPropertyUpdate() {
-    DCHECK_EQ(document().lifecycle().state(), DocumentLifecycle::InPrePaint);
-    m_bitfields.setDescendantNeedsPaintPropertyUpdate(false);
-  }
   // Main thread scrolling reasons require fully updating paint propeties of all
   // ancestors (see: ScrollPaintPropertyNode.h).
   void setAncestorsNeedPaintPropertyUpdateForMainThreadScrolling();
 
   void setIsScrollAnchorObject() { m_bitfields.setIsScrollAnchorObject(true); }
   // Clears the IsScrollAnchorObject bit if and only if no ScrollAnchors still
   // reference this LayoutObject.
   void maybeClearIsScrollAnchorObject();
 
   bool scrollAnchorDisablingStyleChanged() {
@@ skipping 380 matching lines @@
           m_alwaysCreateLineBoxesForLayoutInline(false),
           m_previousBackgroundObscured(false),
           m_isBackgroundAttachmentFixedObject(false),
           m_isScrollAnchorObject(false),
           m_scrollAnchorDisablingStyleChanged(false),
           m_hasBoxDecorationBackground(false),
           m_hasPreviousLocationInBacking(false),
           m_hasPreviousSelectionVisualRect(false),
           m_hasPreviousBoxGeometries(false),
           m_needsPaintPropertyUpdate(true),
+          m_subtreeNeedsPaintPropertyUpdate(true),
           m_descendantNeedsPaintPropertyUpdate(true),
           m_backgroundChangedSinceLastPaintInvalidation(false),
           m_positionedState(IsStaticallyPositioned),
           m_selectionState(SelectionNone),
           m_backgroundObscurationState(BackgroundObscurationStatusInvalid),
           m_fullPaintInvalidationReason(PaintInvalidationNone) {}
 
     // Self needs layout means that this layout object is marked for a full
     // layout. This is the default layout but it is expensive as it recomputes
     // everything. For CSS boxes, this includes the width (laying out the line
@@ skipping 153 matching lines @@
 
     ADD_BOOLEAN_BITFIELD(hasPreviousLocationInBacking,
                          HasPreviousLocationInBacking);
     ADD_BOOLEAN_BITFIELD(hasPreviousSelectionVisualRect,
                          HasPreviousSelectionVisualRect);
     ADD_BOOLEAN_BITFIELD(hasPreviousBoxGeometries, HasPreviousBoxGeometries);
 
     // Whether the paint properties need to be updated. For more details, see
     // LayoutObject::needsPaintPropertyUpdate().
     ADD_BOOLEAN_BITFIELD(needsPaintPropertyUpdate, NeedsPaintPropertyUpdate);
+    // Whether paint properties of the whole subtree need to be updated.
+    ADD_BOOLEAN_BITFIELD(subtreeNeedsPaintPropertyUpdate,
+                         SubtreeNeedsPaintPropertyUpdate)
     // Whether the paint properties of a descendant need to be updated. For more
     // details, see LayoutObject::descendantNeedsPaintPropertyUpdate().
     ADD_BOOLEAN_BITFIELD(descendantNeedsPaintPropertyUpdate,
                          DescendantNeedsPaintPropertyUpdate);
 
     ADD_BOOLEAN_BITFIELD(backgroundChangedSinceLastPaintInvalidation,
                          BackgroundChangedSinceLastPaintInvalidation);
 
    protected:
     // Use protected to avoid warning about unused variable.
-    unsigned m_unusedBits : 7;
+    unsigned m_unusedBits : 6;
 
    private:
     // This is the cached 'position' value of this object
     // (see ComputedStyle::position).
     unsigned m_positionedState : 2;  // PositionedState
     unsigned m_selectionState : 3;   // SelectionState
     // Mutable for getter which lazily update this field.
     mutable unsigned
         m_backgroundObscurationState : 2;        // BackgroundObscurationState
     unsigned m_fullPaintInvalidationReason : 5;  // PaintInvalidationReason
@@ skipping 310 matching lines @@
 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
 // We don't make object2 an optional parameter so that showLayoutTree
 // can be called from gdb easily.
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
                                 const blink::LayoutObject* object2);
 
 #endif
 
 #endif  // LayoutObject_h