@page rule missing from simpleUserAgentStyleSheet.

@page rule missing from simpleUserAgentStyleSheet.

simpleUserAgentStyleSheet did not have an @page rule like html.css.
The result was flakiness for the following test depending on whether the full
UA styles had been triggered by a previous test or not:

LayoutTests/printing/page-format-data.html

R=ojan
BUG=303324
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158866

[ojan, 2013-10-03 18:41:31]

lgtm

Should we add the @viewport rule from html.css here as well for good measure?

[commit-bot: I haz the power, 2013-10-03 18:41:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/25856002/1

[commit-bot: I haz the power, 2013-10-03 18:41:47]

Failed to apply patch for Source/core/css/CSSDefaultStyleSheets.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSDefaultStyleSheets.cpp
  Hunk #1 FAILED at 57.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/CSSDefaultStyleSheets.cpp.rej

Patch:       Source/core/css/CSSDefaultStyleSheets.cpp
Index: Source/core/css/CSSDefaultStyleSheets.cpp
diff --git a/Source/core/css/CSSDefaultStyleSheets.cpp
b/Source/core/css/CSSDefaultStyleSheets.cpp
index
3984e17c41e9ab7781d5b551cff874dcee98af1f..4105a67039b750b46d7ba5bf391da547f4739818
100644
--- a/Source/core/css/CSSDefaultStyleSheets.cpp
+++ b/Source/core/css/CSSDefaultStyleSheets.cpp
@@ -57,7 +57,7 @@ StyleSheetContents*
CSSDefaultStyleSheets::mediaControlsStyleSheet;
 StyleSheetContents* CSSDefaultStyleSheets::fullscreenStyleSheet;
 
 // FIXME: It would be nice to use some mechanism that guarantees this is in
sync with the real UA stylesheet.
-static const char* simpleUserAgentStyleSheet =
"html,body,div{display:block}head{display:none}body{margin:8px}div:focus,span:focus{outline:auto
5px
-webkit-focus-ring-color}a:-webkit-any-link{color:-webkit-link;text-decoration:underline}a:-webkit-any-link:active{color:-webkit-activelink}body:-webkit-seamless-document{margin:0}body:-webkit-full-page-media{background-color:black}@viewport{min-width:980px}";
+static const char* simpleUserAgentStyleSheet =
"html,body,div{display:block}head{display:none}body{margin:8px}div:focus,span:focus{outline:auto
5px
-webkit-focus-ring-color}a:-webkit-any-link{color:-webkit-link;text-decoration:underline}a:-webkit-any-link:active{color:-webkit-activelink}body:-webkit-seamless-document{margin:0}body:-webkit-full-page-media{background-color:black}@viewport{min-width:980px}@page{size:auto;margin:auto;padding:0;border-width:0}";
 
 static inline bool elementCanUseSimpleDefaultStyle(Element* e)
 {

[rune, 2013-10-03 21:02:31]

On 2013/10/03 18:41:31, ojan wrote:
> lgtm
> 
> Should we add the @viewport rule from html.css here as well for good measure?

Already on master[1]. Probably why the patch didn't apply. I must have based
this fix on an older master than I thought. Will fix.

[1] https://codereview.chromium.org/25092003/

[rune, 2013-10-03 21:17:04]

On 2013/10/03 21:02:31, rune wrote:
> On 2013/10/03 18:41:31, ojan wrote:
> > lgtm
> > 
> > Should we add the @viewport rule from html.css here as well for good
measure?
> 
> Already on master[1]. Probably why the patch didn't apply. I must have based
> this fix on an older master than I thought. Will fix.

Bleh. It _was_ already there. It's conflicting with the :focus fix, of course.

[commit-bot: I haz the power, 2013-10-03 21:26:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/25856002/9001

[commit-bot: I haz the power, 2013-10-04 01:49:54]

Change committed as 158866