Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: cc/layers/surface_layer.cc

Issue 2585543003: Revert of Getting rid of CompositorFrameMetadata::satisfies_sequences (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/layers/surface_layer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/surface_layer.h" 5 #include "cc/layers/surface_layer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/threading/thread_task_runner_handle.h"
11 #include "base/trace_event/trace_event.h" 10 #include "base/trace_event/trace_event.h"
12 #include "cc/layers/surface_layer_impl.h" 11 #include "cc/layers/surface_layer_impl.h"
13 #include "cc/output/swap_promise.h" 12 #include "cc/output/swap_promise.h"
14 #include "cc/surfaces/surface_sequence_generator.h" 13 #include "cc/surfaces/surface_sequence_generator.h"
15 #include "cc/trees/layer_tree_host.h" 14 #include "cc/trees/layer_tree_host.h"
16 #include "cc/trees/swap_promise_manager.h" 15 #include "cc/trees/swap_promise_manager.h"
17 16
18 namespace cc { 17 namespace cc {
19 18
20 class SatisfySwapPromise : public SwapPromise { 19 class SatisfySwapPromise : public SwapPromise {
21 public: 20 public:
22 SatisfySwapPromise( 21 SatisfySwapPromise(SurfaceSequence sequence,
23 const SurfaceSequence& sequence, 22 const SurfaceLayer::SatisfyCallback& satisfy_callback)
24 const SurfaceLayer::SatisfyCallback& satisfy_callback, 23 : sequence_(sequence), satisfy_callback_(satisfy_callback) {}
25 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner)
26 : sequence_(sequence),
27 satisfy_callback_(satisfy_callback),
28 main_task_runner_(std::move(main_task_runner)) {}
29 24
30 ~SatisfySwapPromise() override {} 25 ~SatisfySwapPromise() override {}
31 26
32 private: 27 private:
33 void DidActivate() override {} 28 void DidActivate() override {}
34 void WillSwap(CompositorFrameMetadata* metadata) override {} 29 void WillSwap(CompositorFrameMetadata* metadata) override {
35 void DidSwap() override { 30 metadata->satisfies_sequences.push_back(sequence_.sequence);
36 // DidSwap could run on compositor thread but satisfy callback must
37 // run on the main thread.
38 main_task_runner_->PostTask(FROM_HERE,
39 base::Bind(satisfy_callback_, sequence_));
40 } 31 }
32 void DidSwap() override {}
41 33
42 DidNotSwapAction DidNotSwap(DidNotSwapReason reason) override { 34 DidNotSwapAction DidNotSwap(DidNotSwapReason reason) override {
43 main_task_runner_->PostTask(FROM_HERE, 35 satisfy_callback_.Run(sequence_);
44 base::Bind(satisfy_callback_, sequence_));
45 return DidNotSwapAction::BREAK_PROMISE; 36 return DidNotSwapAction::BREAK_PROMISE;
46 } 37 }
47 int64_t TraceId() const override { return 0; } 38 int64_t TraceId() const override { return 0; }
48 39
49 SurfaceSequence sequence_; 40 SurfaceSequence sequence_;
50 SurfaceLayer::SatisfyCallback satisfy_callback_; 41 SurfaceLayer::SatisfyCallback satisfy_callback_;
51 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
52 42
53 DISALLOW_COPY_AND_ASSIGN(SatisfySwapPromise); 43 DISALLOW_COPY_AND_ASSIGN(SatisfySwapPromise);
54 }; 44 };
55 45
56 scoped_refptr<SurfaceLayer> SurfaceLayer::Create( 46 scoped_refptr<SurfaceLayer> SurfaceLayer::Create(
57 const SatisfyCallback& satisfy_callback, 47 const SatisfyCallback& satisfy_callback,
58 const RequireCallback& require_callback) { 48 const RequireCallback& require_callback) {
59 return make_scoped_refptr( 49 return make_scoped_refptr(
60 new SurfaceLayer(satisfy_callback, require_callback)); 50 new SurfaceLayer(satisfy_callback, require_callback));
61 } 51 }
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 ->GetSurfaceSequenceGenerator() 113 ->GetSurfaceSequenceGenerator()
124 ->CreateSurfaceSequence(); 114 ->CreateSurfaceSequence();
125 require_callback_.Run(surface_id_, destroy_sequence_); 115 require_callback_.Run(surface_id_, destroy_sequence_);
126 } 116 }
127 } 117 }
128 118
129 void SurfaceLayer::SatisfyDestroySequence() { 119 void SurfaceLayer::SatisfyDestroySequence() {
130 if (!layer_tree_host()) 120 if (!layer_tree_host())
131 return; 121 return;
132 DCHECK(destroy_sequence_.is_valid()); 122 DCHECK(destroy_sequence_.is_valid());
133 auto satisfy = 123 std::unique_ptr<SatisfySwapPromise> satisfy(
134 base::MakeUnique<SatisfySwapPromise>(destroy_sequence_, satisfy_callback_, 124 new SatisfySwapPromise(destroy_sequence_, satisfy_callback_));
135 base::ThreadTaskRunnerHandle::Get());
136 layer_tree_host()->GetSwapPromiseManager()->QueueSwapPromise( 125 layer_tree_host()->GetSwapPromiseManager()->QueueSwapPromise(
137 std::move(satisfy)); 126 std::move(satisfy));
138 destroy_sequence_ = SurfaceSequence(); 127 destroy_sequence_ = SurfaceSequence();
139 } 128 }
140 129
141 } // namespace cc 130 } // namespace cc
OLDNEW
« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/layers/surface_layer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698