Issue 2585443002: Error checking for Stdio calls

Issue 2585443002: Error checking for Stdio calls (Closed)

Created:
4 years ago by zra

Modified:
4 years ago

Reviewers:
rmacnak, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -91 lines)			Patch
M	runtime/bin/io_natives.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/stdio.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/stdio.cc	View		1 chunk	+28 lines, -5 lines	0 comments	Download
M	runtime/bin/stdio_android.cc	View		1 chunk	+34 lines, -17 lines	0 comments	Download
M	runtime/bin/stdio_fuchsia.cc	View		1 chunk	+8 lines, -6 lines	0 comments	Download
M	runtime/bin/stdio_linux.cc	View		1 chunk	+33 lines, -16 lines	0 comments	Download
M	runtime/bin/stdio_macos.cc	View		1 chunk	+34 lines, -17 lines	0 comments	Download
M	runtime/bin/stdio_patch.dart	View		1 chunk	+38 lines, -9 lines	0 comments	Download
M	runtime/bin/stdio_win.cc	View	1	1 chunk	+18 lines, -15 lines	0 comments	Download
M	sdk/lib/io/stdio.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

zra

On 2016/12/15 18:57:08, Cutch wrote: > LGTM. > > Is it possible to test any ...

4 years ago (2016-12-15 19:09:57 UTC) #4

zra

4 years ago (2016-12-15 19:12:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9506cb9975719fe4475e5d45780cab4426fd5663 (presubmit successful).