third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp - Issue 2585433003: [wrapper-tracing] Reduce marking overhead: Tri-color marking without 3 colors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2585433003: [wrapper-tracing] Reduce marking overhead: Tri-color marking without 3 colors (Closed)

Patch Set: Addressed comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h ('k') | third_party/WebKit/Source/platform/heap/GarbageCollected.h » ('j') | third_party/WebKit/Source/platform/heap/TraceTraits.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

index 0442037da0631ca09164e145afc086535cf88c4c..247f6eace1aa93e88ed324f80a4ec51238f5baaa 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

@@ -188,7 +188,7 @@ TEST(ScriptWrappableVisitorTest, OilpanClearsMarkingDequeWhenObjectDied) {

ScriptWrappableVisitor* visitor =

V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();

visitor->pushToMarkingDeque(

- TraceTrait<DeathAwareScriptWrappable>::markWrapper,

+ TraceTrait<DeathAwareScriptWrappable>::markAndTraceWrapper,

TraceTrait<DeathAwareScriptWrappable>::heapObjectHeader, object);

EXPECT_EQ(visitor->getMarkingDeque()->first().rawObjectPointer(), object);