components/nacl/zygote/nacl_fork_delegate_linux.cc - Issue 258543006: Change UnixDomainSocket::RecvMsg to return ScopedVector<base::ScopedFD>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/zygote/nacl_fork_delegate_linux.cc

Issue 258543006: Change UnixDomainSocket::RecvMsg to return ScopedVector<base::ScopedFD> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove fds->{empty,reserve}() per brettw@ feedback Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/loader/nacl_helper_linux.cc ('K') | « components/nacl/loader/nacl_helper_linux.cc ('k') | content/browser/renderer_host/sandbox_ipc_linux.h » ('j') | content/zygote/zygote_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/zygote/nacl_fork_delegate_linux.cc

diff --git a/components/nacl/zygote/nacl_fork_delegate_linux.cc b/components/nacl/zygote/nacl_fork_delegate_linux.cc

index e6bb77e9b8b0ae3f5a5e576a7699c5377b6ffe4b..ca373dfe6c991cf31b9dfeccfeb7755259e9e610 100644

--- a/components/nacl/zygote/nacl_fork_delegate_linux.cc

+++ b/components/nacl/zygote/nacl_fork_delegate_linux.cc

@@ -18,6 +18,7 @@

#include "base/files/scoped_file.h"

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

+#include "base/memory/scoped_vector.h"

#include "base/path_service.h"

#include "base/pickle.h"

#include "base/posix/eintr_wrapper.h"

@@ -93,7 +94,7 @@ bool SendIPCRequestAndReadReply(int ipc_channel,

}

// Then read the remote reply.

- std::vector<int> received_fds;

+ ScopedVector<base::ScopedFD> received_fds;

const ssize_t msg_len =

UnixDomainSocket::RecvMsg(ipc_channel, reply_data_buffer,

reply_data_buffer_size, &received_fds);