Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: extensions/common/api/audio.idl

Issue 2585413002: Update audio api to use v2 stable device ID (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/audio.idl
diff --git a/extensions/common/api/audio.idl b/extensions/common/api/audio.idl
index 36a1124bd3b66b81339248e984c368cb6b9e5885..f958b4376c6195f368148d5669f3db85e09e8b5d 100644
--- a/extensions/common/api/audio.idl
+++ b/extensions/common/api/audio.idl
@@ -52,7 +52,12 @@ namespace audio {
boolean isMuted;
// The sound level of the device, volume for output, gain for input.
long level;
- // The stable/persisted device id string when available.
+ // The stable/persisted device id string.
+ DOMString stableId;
Devlin 2016/12/20 18:15:45 This is kind of a shame - we now have 3 different
tbarzic 2016/12/20 18:51:20 I guess we could, but at cost of the app losing in
Devlin 2016/12/20 19:36:17 That makes it better. If that's the case, can we
tbarzic 2016/12/20 19:53:56 We could, but imho it would be better to provide t
+
+ // Deprecated version of stable audio device ID. Available for backward
+ // compatibility - usages should be migrated to |stableId|.
+ [deprecated = "Use |stableId|."]
DOMString? stableDeviceId;
};
« no previous file with comments | « extensions/browser/api/audio/audio_service_chromeos.cc ('k') | extensions/test/data/api_test/audio/add_nodes/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698