Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js

Issue 2585393003: DevTools: [Persistence] implement Persistence.subscribeForBindingEvents (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 /** @type {!Set<string>} */ 54 /** @type {!Set<string>} */
55 this._typeDecorationsPending = new Set(); 55 this._typeDecorationsPending = new Set();
56 this._uiSourceCode.addEventListener( 56 this._uiSourceCode.addEventListener(
57 Workspace.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyCha nged, this); 57 Workspace.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyCha nged, this);
58 this._uiSourceCode.addEventListener( 58 this._uiSourceCode.addEventListener(
59 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this); 59 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this);
60 60
61 this._messageAndDecorationListeners = []; 61 this._messageAndDecorationListeners = [];
62 this._installMessageAndDecorationListeners(); 62 this._installMessageAndDecorationListeners();
63 63
64 Persistence.persistence.addEventListener( 64 Persistence.persistence.subscribeForBindingEvent(this._uiSourceCode, this._o nBindingChanged.bind(this));
65 Persistence.Persistence.Events.BindingCreated, this._onBindingChanged, t his);
66 Persistence.persistence.addEventListener(
67 Persistence.Persistence.Events.BindingRemoved, this._onBindingChanged, t his);
68 65
69 this.textEditor.addEventListener( 66 this.textEditor.addEventListener(
70 SourceFrame.SourcesTextEditor.Events.EditorBlurred, 67 SourceFrame.SourcesTextEditor.Events.EditorBlurred,
71 () => UI.context.setFlavor(Sources.UISourceCodeFrame, null)); 68 () => UI.context.setFlavor(Sources.UISourceCodeFrame, null));
72 this.textEditor.addEventListener( 69 this.textEditor.addEventListener(
73 SourceFrame.SourcesTextEditor.Events.EditorFocused, 70 SourceFrame.SourcesTextEditor.Events.EditorFocused,
74 () => UI.context.setFlavor(Sources.UISourceCodeFrame, this)); 71 () => UI.context.setFlavor(Sources.UISourceCodeFrame, this));
75 72
76 this._updateStyle(); 73 this._updateStyle();
77 74
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 676
680 /** 677 /**
681 * @param {!Workspace.UISourceCode.Message} a 678 * @param {!Workspace.UISourceCode.Message} a
682 * @param {!Workspace.UISourceCode.Message} b 679 * @param {!Workspace.UISourceCode.Message} b
683 * @return {number} 680 * @return {number}
684 */ 681 */
685 Workspace.UISourceCode.Message.messageLevelComparator = function(a, b) { 682 Workspace.UISourceCode.Message.messageLevelComparator = function(a, b) {
686 return Workspace.UISourceCode.Message._messageLevelPriority[a.level()] - 683 return Workspace.UISourceCode.Message._messageLevelPriority[a.level()] -
687 Workspace.UISourceCode.Message._messageLevelPriority[b.level()]; 684 Workspace.UISourceCode.Message._messageLevelPriority[b.level()];
688 }; 685 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698