Issue 2585373002: modified libyuv.gyp so that it no longer depends on libjpeg.gyp, which does not exist anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2585373002: modified libyuv.gyp so that it no longer depends on libjpeg.gyp, which does not exist anymore. (Closed)

Created:
4 years ago by fbarchard1

Modified:
4 years ago

Reviewers:
kjellander_chromium

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

modified libyuv.gyp so that it no longer depends on libjpeg.gyp, which does not exist anymore. BUG=libyuv:666 TESTED= unittests built and passed with jpeg disabled. R=kjellander@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/bd10875846ae4d9894c0c213a60b467a5fb48bb3

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	libyuv.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	libyuv_test.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

fbarchard1

Disabled JPEG whem built with GYP. No impact on GN builds which still support jpeg.

4 years ago (2016-12-19 19:49:09 UTC) #2

kjellander_chromium

lgtm, but at some point we need to do changes like this downstream only, and ...

4 years ago (2016-12-19 19:56:54 UTC) #3

fbarchard1

4 years ago (2016-12-19 19:57:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd10875846ae4d9894c0c213a60b467a5fb48bb3 (presubmit successful).