Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall.php

Issue 2585363002: Use FeaturePolicy to implement iframe[allowfullscreen] (Closed)
Patch Set: Avoid extra change event notification Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall.php b/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall.php
index 18f970a9edce354fc206c52940e6a529a2ecd414..88e9cdbf6c32477509fb956e9c299dcb333854c1 100644
--- a/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall.php
+++ b/third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall.php
@@ -4,8 +4,8 @@
// found in the LICENSE file.
// This test ensures that fullscreen feature when enabled for all works across
-// origins when allowfullscreen is set. No iframe may call it when
-// allowfullscreen is not set.
+// origins regardless of whether allowfullscreen is set. (Feature policy header
+// takes precedence over the absence of allowfullscreen.)
Header("Feature-Policy: {\"fullscreen\": [\"*\"]}");
?>
@@ -32,13 +32,8 @@ function loadFrames(iframe) {
resolve(e.data);
}, { once: true });
}).then(function(data) {
- if (iframe.id === "f2") {
- assert_true(data.enabled, 'Document.fullscreenEnabled:');
- assert_equals(data.type, 'change', 'Document.requestFullscreen():');
- } else {
- assert_false(data.enabled, 'Document.fullscreenEnabled:');
- assert_equals(data.type, 'error', 'Document.requestFullscreen():');
- }
+ assert_true(data.enabled, 'Document.fullscreenEnabled:');
+ assert_equals(data.type, 'change', 'Document.requestFullscreen():');
});
}, 'Fullscreen enabled for all on URL: ' + src + ' with allowfullscreen = ' + iframe.allowFullscreen);
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/feature-policy/fullscreen-enabledforall-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698