Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258533003: Reland "Remove remaining window states where window is shown with opacity 0. (https://codereview.ch… (Closed)

Created:
6 years, 8 months ago by flackr
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, ben+aura_chromium.org, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Reland Remove remaining window states where window is shown with opacity 0. https://codereview.chromium.org/237963019/ BUG=351553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266041

Patch Set 1 #

Patch Set 2 : Don't re-enable the DCHECK yet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -37 lines) Patch
M ash/shelf/shelf_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/shelf/shelf_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_overview.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 4 chunks +11 lines, -4 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 8 chunks +29 lines, -17 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
flackr
What do you think of relanding these overview and panel opacity fixes without enabling the ...
6 years, 8 months ago (2014-04-24 15:31:31 UTC) #1
sky
Fine by me. LGTM
6 years, 8 months ago (2014-04-24 16:28:25 UTC) #2
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 8 months ago (2014-04-24 16:46:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/258533003/20001
6 years, 8 months ago (2014-04-24 16:48:15 UTC) #4
Mr4D (OOO till 08-26)
lgtm
6 years, 8 months ago (2014-04-24 18:41:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 21:07:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 21:07:24 UTC) #7
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 8 months ago (2014-04-24 21:10:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/258533003/20001
6 years, 8 months ago (2014-04-24 21:35:04 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:33:07 UTC) #10
Message was sent while issue was closed. 
Change committed as 266041

Powered by Google App Engine
This is Rietveld 408576698