Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2585283002: Migrate WTF::Vector::append() to ::push_back() [part 6 of N] (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index 75a10138695dd95f2cbed592f670964c097d269b..9ad3a4666e206f1cbd17b7262b3a836122a86a68 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -311,7 +311,7 @@ void ResourceFetcher::requestLoadStarted(unsigned long identifier,
populateResourceTiming(info.get(), resource);
info->clearLoadTimings();
info->setLoadFinishTime(info->initialTime());
- m_scheduledResourceTimingReports.append(std::move(info));
+ m_scheduledResourceTimingReports.push_back(std::move(info));
if (!m_resourceTimingReportTimer.isActive())
m_resourceTimingReportTimer.startOneShot(0, BLINK_FROM_HERE);
}
@@ -507,9 +507,9 @@ Resource* ResourceFetcher::requestResource(
if (activityLogger) {
Vector<String> argv;
- argv.append(Resource::resourceTypeToString(
+ argv.push_back(Resource::resourceTypeToString(
factory.type(), request.options().initiatorInfo.name));
- argv.append(request.url());
+ argv.push_back(request.url());
activityLogger->logEvent("blinkRequestResource", argv.size(),
argv.data());
}
@@ -1260,9 +1260,9 @@ void ResourceFetcher::removeResourceLoader(ResourceLoader* loader) {
void ResourceFetcher::stopFetching() {
HeapVector<Member<ResourceLoader>> loadersToCancel;
for (const auto& loader : m_nonBlockingLoaders)
- loadersToCancel.append(loader);
+ loadersToCancel.push_back(loader);
for (const auto& loader : m_loaders)
- loadersToCancel.append(loader);
+ loadersToCancel.push_back(loader);
for (const auto& loader : loadersToCancel) {
if (m_loaders.contains(loader) || m_nonBlockingLoaders.contains(loader))
« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698