Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.cpp

Issue 2585283002: Migrate WTF::Vector::append() to ::push_back() [part 6 of N] (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/Resource.cpp b/third_party/WebKit/Source/core/fetch/Resource.cpp
index 5fc76d90d22709d569684303de53f0f6d0c44428..f3959e7d5e2a25116f17057fca9120e5b1a4922f 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.cpp
+++ b/third_party/WebKit/Source/core/fetch/Resource.cpp
@@ -295,7 +295,7 @@ bool Resource::ResourceCallback::isScheduled(Resource* resource) const {
void Resource::ResourceCallback::runTask() {
HeapVector<Member<Resource>> resources;
for (const Member<Resource>& resource : m_resourcesWithPendingClients)
- resources.append(resource.get());
+ resources.push_back(resource.get());
m_resourcesWithPendingClients.clear();
for (const auto& resource : resources)
@@ -585,7 +585,7 @@ bool Resource::willFollowRedirect(const ResourceRequest& newRequest,
const ResourceResponse& redirectResponse) {
if (m_isRevalidating)
revalidationFailed();
- m_redirectChain.append(RedirectPair(newRequest, redirectResponse));
+ m_redirectChain.push_back(RedirectPair(newRequest, redirectResponse));
return true;
}
@@ -889,13 +889,13 @@ void Resource::onMemoryDump(WebMemoryDumpLevelOfDetail levelOfDetail,
Vector<String> clientNames;
ResourceClientWalker<ResourceClient> walker(m_clients);
while (ResourceClient* client = walker.next())
- clientNames.append(client->debugName());
+ clientNames.push_back(client->debugName());
ResourceClientWalker<ResourceClient> walker2(m_clientsAwaitingCallback);
while (ResourceClient* client = walker2.next())
- clientNames.append("(awaiting) " + client->debugName());
+ clientNames.push_back("(awaiting) " + client->debugName());
ResourceClientWalker<ResourceClient> walker3(m_finishedClients);
while (ResourceClient* client = walker3.next())
- clientNames.append("(finished) " + client->debugName());
+ clientNames.push_back("(finished) " + client->debugName());
std::sort(clientNames.begin(), clientNames.end(),
WTF::codePointCompareLessThan);
« no previous file with comments | « third_party/WebKit/Source/core/fetch/MemoryCache.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698