Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2585263005: Merge "Fix form validation bubble positioning at hidpi." to M56 (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge "Fix form validation bubble positioning at hidpi." to M56 Since use-zoom-for-dsf launched, when Blink converts to screen coordinates it needs to take the device scale factor into account. Normally it would do this by calling viewportToScreen or a similar function. However, because the validation bubble anchor is in viewport coordinates instead of screen coordinates, the positioning code needs to use device scale factor explicitly. The reason we can't just convert the anchor to screen coordinates in Blink is because the same anchor is used for cocoa. It needs to y-flip the anchor for OSX and converting to screen coordinates too early messes up that calculation. BUG=660840 Review-Url: https://codereview.chromium.org/2491113002 Cr-Commit-Position: refs/heads/master@{#433349} (cherry picked from commit 5debc705a0b892bd2dcf82ec7672147268083957) Committed: https://chromium.googlesource.com/chromium/src/+/1f010f3da574e93bfafb68a0149ae8d350202e71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M chrome/browser/ui/views/validation_message_bubble_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/validation_message_bubble_view.cc View 4 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years ago (2016-12-20 01:56:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f010f3da574e93bfafb68a0149ae8d350202e71.

Powered by Google App Engine
This is Rietveld 408576698