Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: components/password_manager/core/browser/password_reuse_detector.cc

Issue 2585253002: Integration of PasswordReuseDetector into PasswordStore. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_reuse_detector.cc
diff --git a/components/password_manager/core/browser/password_reuse_detector.cc b/components/password_manager/core/browser/password_reuse_detector.cc
index cde8904e2c84359ac1e7c074d0ae26992724f778..bcb4790c416ef63a661646828326693da2e23cf2 100644
--- a/components/password_manager/core/browser/password_reuse_detector.cc
+++ b/components/password_manager/core/browser/password_reuse_detector.cc
@@ -5,6 +5,7 @@
#include "components/password_manager/core/browser/password_reuse_detector.h"
#include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/core/browser/password_reuse_detector_consumer.h"
#include "components/password_manager/core/browser/psl_matching_helper.h"
namespace password_manager {
@@ -22,14 +23,16 @@ PasswordReuseDetector::~PasswordReuseDetector() {}
void PasswordReuseDetector::OnGetPasswordStoreResults(
std::vector<std::unique_ptr<autofill::PasswordForm>> results) {
- passwords_.clear();
- for (const auto& form : results) {
- const base::string16& password = form->password_value;
- if (password.size() < kMinPasswordLengthToCheck)
- continue;
- GURL signon_realm(form->signon_realm);
- const std::string domain = GetRegistryControlledDomain(signon_realm);
- passwords_[password].insert(domain);
+ for (const auto& form : results)
+ AddPassword(*form);
+}
+
+void PasswordReuseDetector::OnLoginsChanged(
+ const PasswordStoreChangeList& changes) {
+ for (const auto& change : changes) {
+ if (change.type() == PasswordStoreChange::ADD ||
+ change.type() == PasswordStoreChange::UPDATE)
+ AddPassword(change.form());
}
}
@@ -59,4 +62,13 @@ void PasswordReuseDetector::CheckReuse(
}
}
+void PasswordReuseDetector::AddPassword(const autofill::PasswordForm& form) {
+ const base::string16& password = form.password_value;
+ if (password.size() < kMinPasswordLengthToCheck)
+ return;
+ GURL signon_realm(form.signon_realm);
+ const std::string domain = GetRegistryControlledDomain(signon_realm);
+ passwords_[password].insert(domain);
+}
+
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698