Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 2585253002: Integration of PasswordReuseDetector into PasswordStore. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
index 9acf39184ed90bc0fb35a6265dfaf9abe830dfe9..cf9eeb764eb037f52f61940770e677962809f9e1 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
@@ -116,6 +116,16 @@ class ManagePasswordsBubbleModelTest : public ::testing::Test {
password_manager::BuildPasswordStore<
content::BrowserContext,
testing::StrictMock<password_manager::MockPasswordStore>>);
+#if !defined(OS_MACOSX)
+ // TODO(crbug.com/668155): Remove conditional compilation when
+ // PasswordReuseDetector initialization will be implemented for Mac.
+ // The call of FillAutofillableLogins is caused by a posted task for an
+ // initialization of PasswordReuseDetector in the call of
+ // BuildPasswordStore() in the previous code. There is no thread race since
+ // unit tests run in one thread, and any post task will be executed after
+ // finishing the current function.
+ EXPECT_CALL(*GetStore(), FillAutofillableLogins(_));
+#endif
}
void TearDown() override {
« no previous file with comments | « no previous file | components/password_manager/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698