Integration of PasswordReuseDetector into PasswordStore.

chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
index 16b4c3b4ff07a1180936d84a9c817edd45766c2e..1492332536d35030cc9ba6725c912645f20d1f3b 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
@@ -110,6 +110,7 @@ class ManagePasswordsBubbleModelTest : public ::testing::Test {
         password_manager::BuildPasswordStore<
             content::BrowserContext,
             testing::StrictMock<password_manager::MockPasswordStore>>);
+    EXPECT_CALL(*GetStore(), FillAutofillableLogins(_));

[vabr (Chromium), 2016/12/22 16:15:12]

It is a bit strange to expect a call and then return the function. Normally the
code which will result in the expected call should be below the EXPECT macro.
What is causing the call to FillAutofillableLogins? Could you put the
EXPECT_CALL before that?

[dvadym, 2016/12/22 16:23:12]

PasswordStore initializes PasswordReuseDetector, and it causes call of
FillAutofillableLogins. So a call of BuildPasswordStore itself causes a call of
FillAutofillableLogins, but since it's on a posted task it happens after
returning from BuildPasswordStore. 
Note that there is no thread race, since unit tests are running on 1 thread and
any posted task is always running after current function execution is finished.
I can explain all this in comments? Would it be ok?

[vabr (Chromium), 2016/12/22 16:33:30]

Thanks for the explanation. In that case please move the EXPECT_CALL before line
108. You might comment on the expectation being fulfilled in a task posted as a
result of the call below.

[dvadym, 2016/12/22 16:57:57]

If I correctly understand, line 108 creates password store, so I can't use
EXPECT_CALL on store object before it.

[vabr (Chromium), 2016/12/22 17:14:31]

You are right, sorry for missing that!
Then please do comment that the expectation is met in a task posted by the above
construction.

[dvadym, 2016/12/22 17:31:18]

Thanks, I've updated comment.

   }
 
   void TearDown() override {