Integration of PasswordReuseDetector into PasswordStore.

components/password_manager/core/browser/password_reuse_detector.cc

Index: components/password_manager/core/browser/password_reuse_detector.cc
diff --git a/components/password_manager/core/browser/password_reuse_detector.cc b/components/password_manager/core/browser/password_reuse_detector.cc
index cde8904e2c84359ac1e7c074d0ae26992724f778..d258931be653125506bb73a36349104100104c14 100644
--- a/components/password_manager/core/browser/password_reuse_detector.cc
+++ b/components/password_manager/core/browser/password_reuse_detector.cc
@@ -22,14 +22,16 @@ PasswordReuseDetector::~PasswordReuseDetector() {}
 
 void PasswordReuseDetector::OnGetPasswordStoreResults(
     std::vector<std::unique_ptr<autofill::PasswordForm>> results) {
-  passwords_.clear();
-  for (const auto& form : results) {
-    const base::string16& password = form->password_value;
-    if (password.size() < kMinPasswordLengthToCheck)
-      continue;
-    GURL signon_realm(form->signon_realm);
-    const std::string domain = GetRegistryControlledDomain(signon_realm);
-    passwords_[password].insert(domain);
+  for (const auto& form : results)
+    AddPassword(*form.get());
+}
+
+void PasswordReuseDetector::OnLoginsChanged(
+    const PasswordStoreChangeList& changes) {
+  for (const auto& change : changes) {
+    if (change.type() == PasswordStoreChange::ADD ||

[vabr (Chromium), 2016/12/20 18:11:44]

Why are we not removing passwords when they get deleted?

[dvadym, 2016/12/21 12:15:35]

That's hard to do 100% correct: if the user removed duplicating credentials from
store, in |passwords_| we don't have information how many times specific
password occurred and we can delete still valid password. But it looks like not
deleting passwords are not the big problem:
 1.It's rare.
 2.False positive is better than false negative.
 3.After Chrome restarts passwords will be deleted.

[vabr (Chromium), 2016/12/21 14:38:19]

Acknowledged, this makes sense.

+        change.type() == PasswordStoreChange::UPDATE)
+      AddPassword(change.form());
   }
 }
 
@@ -59,4 +61,13 @@ void PasswordReuseDetector::CheckReuse(
   }
 }
 
+void PasswordReuseDetector::AddPassword(const autofill::PasswordForm& form) {
+  const base::string16& password = form.password_value;
+  if (password.size() < kMinPasswordLengthToCheck)
+    return;
+  GURL signon_realm(form.signon_realm);
+  const std::string domain = GetRegistryControlledDomain(signon_realm);
+  passwords_[password].insert(domain);
+}
+
 }  // namespace password_manager