Stop passing chrome.test.fail as ErrorCallback

Stop passing chrome.test.fail as ErrorCallback

chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
This wrong use of chrome.test.fail makes the error output useless when something goes wrong.

BUG=None
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266271

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267077

[hashimoto, 2014-04-24 11:13:33]

Please review.

This wrong use of chrome.test.fail results in terminating the test ungracefully
with an exception like this:

uncaught exception: Error: Invocation of form test.fail(string, string) doesn't
match definition test.fail(optional any message)
Error
    at Object.<anonymous> (extensions::test:97:20)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.handleRequest (extensions::binding:55:27)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.<anonymous> (extensions::binding:318:32)", source:
chrome-extension://ddammdhioacbehjngdmkjcjbnfginlla/_generated_background_page.html
(0)

[hirono, 2014-04-25 02:30:11]

Thank you for doing this. LGTM!

[hashimoto, 2014-04-25 02:32:27]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:35:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/258523004/20001

[commit-bot: I haz the power, 2014-04-25 23:02:26]

Change committed as 266271

[tapted, 2014-04-28 00:34:13]

A revert of this CL has been created in
https://codereview.chromium.org/254943002/ by tapted@chromium.org.

The reason for reverting is: Suspected for making
OpenAudioFiles/FileManagerBrowserTest.Test/{0,1} flaky/racy since
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Errors like: 

[26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in
undefined: Displayed data of 1st file is wrong.
Actual: Beautiful Song.ogg
Expected: Beautiful Song
...
    at
chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/open_audio_files.js:90:21",
source:
chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html
(0)
[26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined:
chrome.test.failure.

[hirono, 2014-04-28 04:03:19]

On 2014/04/28 00:34:13, tapted wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/254943002/ by mailto:tapted@chromium.org.
> 
> The reason for reverting is: Suspected for making
> OpenAudioFiles/FileManagerBrowserTest.Test/{0,1} flaky/racy since
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
> 
> Errors like: 
> 
> [26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in
> undefined: Displayed data of 1st file is wrong.
> Actual: Beautiful Song.ogg
> Expected: Beautiful Song
> ...
>     at
>
chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/open_audio_files.js:90:21",
> source:
>
chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html
> (0)
> [26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined:
> chrome.test.failure.

The patch is not related with the error.
I'll make a patch to fix the error. Please resubmit this CL.

[hashimoto, 2014-04-30 03:58:28]

On 2014/04/28 04:03:19, hirono wrote:
> On 2014/04/28 00:34:13, tapted wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/254943002/ by mailto:tapted@chromium.org.
> > 
> > The reason for reverting is: Suspected for making
> > OpenAudioFiles/FileManagerBrowserTest.Test/{0,1} flaky/racy since
> >
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
> > 
> > Errors like: 
> > 
> > [26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error
in
> > undefined: Displayed data of 1st file is wrong.
> > Actual: Beautiful Song.ogg
> > Expected: Beautiful Song
> > ...
> >     at
> >
>
chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/open_audio_files.js:90:21",
> > source:
> >
>
chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html
> > (0)
> > [26400:26400:0426/004939:INFO:CONSOLE(0)] "[FAIL] undefined:
> > chrome.test.failure.
> 
> The patch is not related with the error.
> I'll make a patch to fix the error. Please resubmit this CL.

Thanks hirono for fixing the real cause of the failure.
Relanding this.

[hashimoto, 2014-04-30 03:58:32]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-04-30 04:00:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/258523004/20001

[commit-bot: I haz the power, 2014-04-30 05:08:41]

Change committed as 267077