Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 2585203003: Don't try to report metrics when there's no URLRequest (Closed)
Patch Set: make executor reject tasks Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/cronet_url_request_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc
index 253b0a5659b8535c12fb1ac5bb07a21048598598..19437d59c9ec815557188fb4efbfe765550ad5ec 100644
--- a/components/cronet/android/cronet_url_request_adapter.cc
+++ b/components/cronet/android/cronet_url_request_adapter.cc
@@ -402,7 +402,11 @@ void CronetURLRequestAdapter::ReportError(net::URLRequest* request,
}
void CronetURLRequestAdapter::MaybeReportMetrics(JNIEnv* env) const {
- if (!enable_metrics_) {
+ // If there was an exception while starting the CronetUrlRequest, there won't
+ // be a native URLRequest. In this case, the caller gets the exception
+ // immediately, and the onFailed callback isn't called, so don't report
+ // metrics either.
+ if (!enable_metrics_ || !url_request_) {
return;
}
net::LoadTimingInfo metrics;
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698