Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: content/browser/devtools/shared_worker_devtools_manager_unittest.cc

Issue 258513002: Introduce WorkerStoragePartitionId and use it in SharedWorkerInstance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Hold WorkerStoragePartition in SharedWorkerMessageFilter Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/shared_worker/shared_worker_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/shared_worker_devtools_manager_unittest.cc
diff --git a/content/browser/devtools/shared_worker_devtools_manager_unittest.cc b/content/browser/devtools/shared_worker_devtools_manager_unittest.cc
index 5b4e536971707b55df7d317c171ea9270058a871..0f987b7d2fa417710741756051e78e3c5c05ea6d 100644
--- a/content/browser/devtools/shared_worker_devtools_manager_unittest.cc
+++ b/content/browser/devtools/shared_worker_devtools_manager_unittest.cc
@@ -46,7 +46,8 @@ class SharedWorkerDevToolsManagerTest : public testing::Test {
NULL,
NULL,
NULL,
- NULL)) {}
+ NULL)),
+ partition_id_(*partition_.get()) {}
protected:
virtual void SetUp() OVERRIDE {
@@ -91,6 +92,7 @@ class SharedWorkerDevToolsManagerTest : public testing::Test {
BrowserThreadImpl ui_thread_;
scoped_ptr<TestBrowserContext> browser_context_;
scoped_ptr<WorkerStoragePartition> partition_;
+ const WorkerStoragePartitionId partition_id_;
SharedWorkerDevToolsManager* manager_;
};
@@ -102,7 +104,7 @@ TEST_F(SharedWorkerDevToolsManagerTest, BasicTest) {
base::string16(),
blink::WebContentSecurityPolicyTypeReport,
browser_context_->GetResourceContext(),
- *partition_.get());
+ partition_id_);
agent_host = manager_->GetDevToolsAgentHostForWorker(1, 1);
EXPECT_FALSE(agent_host.get());
@@ -182,13 +184,13 @@ TEST_F(SharedWorkerDevToolsManagerTest, AttachTest) {
base::string16(),
blink::WebContentSecurityPolicyTypeReport,
browser_context_->GetResourceContext(),
- *partition_.get());
+ partition_id_);
SharedWorkerInstance instance2(GURL("http://example.com/w2.js"),
base::string16(),
base::string16(),
blink::WebContentSecurityPolicyTypeReport,
browser_context_->GetResourceContext(),
- *partition_.get());
+ partition_id_);
// Created -> GetDevToolsAgentHost -> Register -> Started -> Destroyed
scoped_ptr<TestDevToolsClientHost> client_host1(new TestDevToolsClientHost());
« no previous file with comments | « no previous file | content/browser/shared_worker/shared_worker_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698