content/browser/shared_worker/shared_worker_message_filter.h - Issue 258513002: Introduce WorkerStoragePartitionId and use it in SharedWorkerInstance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/shared_worker_message_filter.h

Issue 258513002: Introduce WorkerStoragePartitionId and use it in SharedWorkerInstance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/shared_worker/shared_worker_instance_unittest.cc ('k') | content/browser/shared_worker/shared_worker_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/shared_worker/shared_worker_message_filter.h

diff --git a/content/browser/shared_worker/shared_worker_message_filter.h b/content/browser/shared_worker/shared_worker_message_filter.h

index 7ca41c286e33758684e4b86949178efe031e9eb4..1a0d2e1f67a2beb28a326ea4c014b93083e8265a 100644

--- a/content/browser/shared_worker/shared_worker_message_filter.h

+++ b/content/browser/shared_worker/shared_worker_message_filter.h

@@ -68,7 +68,7 @@ class CONTENT_EXPORT SharedWorkerMessageFilter : public BrowserMessageFilter {

const int render_process_id_;

ResourceContext* const resource_context_;

- const WorkerStoragePartition partition_;

+ const WorkerStoragePartitionId partition_id_;

michaeln 2014/04/24 08:04:32 The bug has to do with the devtools holding onto r

horo 2014/04/24 08:23:15 Done. Oh yes. SharedWorkerMessageFilter should hol

MessagePortMessageFilter* const message_port_message_filter_;

DISALLOW_IMPLICIT_CONSTRUCTORS(SharedWorkerMessageFilter);