Issue 258503007: Use EventSender class in HTMLSourceElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258503007: Use EventSender class in HTMLSourceElement (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
tkent, esprehn

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use EventSender class in HTMLSourceElement Use EventSender class in HTMLSourceElement to avoid duplicating the asynchronous event dispatch code. R=esprehn@chromium.org, tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172560

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -13 lines)			Patch
	M	Source/core/html/HTMLSourceElement.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
	M	Source/core/html/HTMLSourceElement.cpp	View		4 chunks	+17 lines, -9 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm https://codereview.chromium.org/258503007/diff/1/Source/core/html/HTMLSourceElement.cpp File Source/core/html/HTMLSourceElement.cpp (right): https://codereview.chromium.org/258503007/diff/1/Source/core/html/HTMLSourceElement.cpp#newcode112 Source/core/html/HTMLSourceElement.cpp:112: WTF_LOG(Media, "HTMLSourceElement::dispatchPendingEvent - %p", this); All these logs ...

6 years, 8 months ago (2014-04-24 20:49:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/258503007/1

6 years, 8 months ago (2014-04-24 20:50:46 UTC) #3

Message was sent while issue was closed.

Change committed as 172560

Expand Messages | Collapse Messages