Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 258503006: Do not bail out early from TiclInvalidationService for managed profiles (Closed)

Created:
6 years, 8 months ago by bartfab (slow)
Modified:
6 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, Marc Treib
Visibility:
Public.

Description

Do not bail out early from TiclInvalidationService for managed profiles There is no need to explicitly check whether the profile is managed when trying to start the TiclInvalidationService. The service will refuse to start up anyway because managed profiles never have a signed-in account. BUG=358696 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266303

Patch Set 1 #

Patch Set 2 : Do instantiate TiclInvalidationService for managed profiles. It is needed as a dependency, even if … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/invalidation/ticl_invalidation_service.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bartfab (slow)
Hi Daniel, I isolated the piece of CL 255443005 that you wanted to have in ...
6 years, 8 months ago (2014-04-24 18:58:29 UTC) #1
dcheng
lgtm
6 years, 8 months ago (2014-04-24 19:00:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/258503006/1
6 years, 8 months ago (2014-04-24 21:49:50 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:45:26 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 23:45:26 UTC) #5
bartfab (slow)
Marc, As discussed offline, I am simply removing the is-profile-managed check now.
6 years, 8 months ago (2014-04-25 08:20:56 UTC) #6
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 8 months ago (2014-04-25 08:20:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/258503006/30001
6 years, 8 months ago (2014-04-25 08:31:20 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 00:38:21 UTC) #9
Message was sent while issue was closed.
Change committed as 266303

Powered by Google App Engine
This is Rietveld 408576698