Issue 258503003: Remove smiluate-touch-screen-with-mouse content flag.

Issue 258503003: Remove smiluate-touch-screen-with-mouse content flag. (Closed)

Created:
6 years, 8 months ago by dgozman

Modified:
6 years, 7 months ago

Reviewers:
aelias_OOO_until_Jul13, jochen (gone - plz use gerrit)

CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove smiluate-touch-screen-with-mouse content flag. This is duplicated functionality now, as one can use DevTools touch emulation instead. BUG=337142 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266549

Patch Set 1 #

Patch Set 2 : Fixed compile. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -115 lines)			Patch
M	content/browser/renderer_host/input/input_router_impl.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/input/input_router_impl.cc	View	1	3 chunks	+0 lines, -106 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/258503003/1

6 years, 8 months ago (2014-04-25 13:16:02 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-25 23:39:52 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg

6 years, 8 months ago (2014-04-25 23:39:53 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/258503003/20001

6 years, 7 months ago (2014-04-28 09:43:31 UTC) #9

Nico

6 years, 7 months ago (2014-04-28 18:13:08 UTC) #11

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/260123003/ by thakis@chromium.org.

The reason for reverting is: Somewhat speculative; looks like this caused
TouchEmulatorTest failures on valgrind:

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28t...

TouchEmulatorTest.Pinch:
../../content/browser/renderer_host/input/touch_emulator_unittest.cc:254:
Failure
Value of: ExpectedEvents()
Actual: "TouchEnd GestureFlingStart"
Expected: "TouchEnd GestureScrollEnd"

etc.

Expand Messages | Collapse Messages