Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/exo/compositor_frame_sink_holder.cc

Issue 2584953002: exo::CompositorFrameSinkHolder's release callbacks hold ref (Closed)
Patch Set: Addressed comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/compositor_frame_sink_holder.cc
diff --git a/components/exo/compositor_frame_sink_holder.cc b/components/exo/compositor_frame_sink_holder.cc
index dcd3110ab6ea9cb7a03a31a22d1e5b44cb906787..e6cb2b8db280e76757e573423cad863d478f8069 100644
--- a/components/exo/compositor_frame_sink_holder.cc
+++ b/components/exo/compositor_frame_sink_holder.cc
@@ -4,7 +4,6 @@
#include "components/exo/compositor_frame_sink_holder.h"
-#include "base/memory/ptr_util.h"
#include "cc/resources/returned_resource.h"
#include "components/exo/surface.h"
@@ -30,10 +29,11 @@ bool CompositorFrameSinkHolder::HasReleaseCallbackForResource(
return release_callbacks_.find(id) != release_callbacks_.end();
}
-void CompositorFrameSinkHolder::AddResourceReleaseCallback(
+void CompositorFrameSinkHolder::SetResourceReleaseCallback(
cc::ResourceId id,
- std::unique_ptr<cc::SingleReleaseCallback> callback) {
- release_callbacks_[id] = std::make_pair(this, std::move(callback));
+ const cc::ReleaseCallback& callback) {
+ DCHECK(!callback.is_null());
+ release_callbacks_[id] = callback;
}
void CompositorFrameSinkHolder::ActivateFrameCallbacks(
@@ -84,10 +84,10 @@ void CompositorFrameSinkHolder::ReclaimResources(
for (auto& resource : resources) {
auto it = release_callbacks_.find(resource.id);
DCHECK(it != release_callbacks_.end());
- std::unique_ptr<cc::SingleReleaseCallback> callback =
- std::move(it->second.second);
- release_callbacks_.erase(it);
- callback->Run(resource.sync_token, resource.lost);
+ if (it != release_callbacks_.end()) {
+ it->second.Run(resource.sync_token, resource.lost);
+ release_callbacks_.erase(it);
+ }
}
}
@@ -126,7 +126,10 @@ void CompositorFrameSinkHolder::OnSurfaceDestroying(Surface* surface) {
////////////////////////////////////////////////////////////////////////////////
// ExoComopositorFrameSink, private:
-CompositorFrameSinkHolder::~CompositorFrameSinkHolder() {}
+CompositorFrameSinkHolder::~CompositorFrameSinkHolder() {
+ if (surface_)
+ surface_->RemoveSurfaceObserver(this);
+}
void CompositorFrameSinkHolder::UpdateNeedsBeginFrame() {
if (!begin_frame_source_)

Powered by Google App Engine
This is Rietveld 408576698