Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: components/exo/buffer_unittest.cc

Issue 2584953002: exo::CompositorFrameSinkHolder's release callbacks hold ref (Closed)
Patch Set: Use ScopedClosureRunner Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/buffer_unittest.cc
diff --git a/components/exo/buffer_unittest.cc b/components/exo/buffer_unittest.cc
index 987c29056538f8a580c6c9eedddd5c5583d68a9d..af1c24018d16d9f4f0886de10866b29e0ab3aa19 100644
--- a/components/exo/buffer_unittest.cc
+++ b/components/exo/buffer_unittest.cc
@@ -41,7 +41,7 @@ TEST_F(BufferTest, ReleaseCallback) {
// Produce a texture mailbox for the contents of the buffer.
cc::TextureMailbox texture_mailbox;
std::unique_ptr<cc::SingleReleaseCallback> buffer_release_callback =
- buffer->ProduceTextureMailbox(&texture_mailbox, false, true);
+ buffer->ProduceTextureMailbox(&texture_mailbox, false, true, nullptr);
ASSERT_TRUE(buffer_release_callback);
// Release buffer.
@@ -64,7 +64,7 @@ TEST_F(BufferTest, IsLost) {
// Acquire a texture mailbox for the contents of the buffer.
cc::TextureMailbox texture_mailbox;
std::unique_ptr<cc::SingleReleaseCallback> buffer_release_callback =
- buffer->ProduceTextureMailbox(&texture_mailbox, false, true);
+ buffer->ProduceTextureMailbox(&texture_mailbox, false, true, nullptr);
ASSERT_TRUE(buffer_release_callback);
scoped_refptr<cc::ContextProvider> context_provider =
@@ -83,7 +83,7 @@ TEST_F(BufferTest, IsLost) {
// Producing a new texture mailbox for the contents of the buffer.
std::unique_ptr<cc::SingleReleaseCallback> buffer_release_callback2 =
- buffer->ProduceTextureMailbox(&texture_mailbox, false, false);
+ buffer->ProduceTextureMailbox(&texture_mailbox, false, false, nullptr);
ASSERT_TRUE(buffer_release_callback2);
buffer->OnDetach();

Powered by Google App Engine
This is Rietveld 408576698