Issue 2584943002: Remove Dart_CreateLibrarySnapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2584943002: Remove Dart_CreateLibrarySnapshot. (Closed)

Created:
4 years ago by rmacnak

Modified:
4 years ago

Reviewers:
Cutch, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove Dart_CreateLibrarySnapshot. This API was never used by Dartium, Flutter or Standalone. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/2f532ab58bf23ede3f44a40649802ac70b9fb418

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -86 lines)			Patch
M	runtime/include/dart_api.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	3 chunks	+4 lines, -24 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1 chunk	+0 lines, -41 lines	0 comments	Download

Total messages: 6 (2 generated)

rmacnak

Committed patchset #1 (id:1) manually as 2f532ab58bf23ede3f44a40649802ac70b9fb418 (presubmit successful).

4 years ago (2016-12-16 23:06:09 UTC) #5

siva

4 years ago (2016-12-20 01:18:21 UTC) #6

Message was sent while issue was closed.

I believe this API was added by Adam as he thought it would be used by flutter.
Did you check with him?