Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2584893004: luci_deploy: Enable loading "index.yaml" directly. (Closed)

Created:
4 years ago by dnj
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

luci_deploy: Enable loading "index.yaml" directly. "index.yaml" is a somewhat special configuration file, in that `dev_appserver` is able to directly generate it in response to index operation observations. Rather than force the user to manually translate between "index.yaml" and the AppEngineResource's Index protobuf, add the ability to load an "index.yaml" file directly into "luci_deploy". This will also lower the barrier to migrating existing applciations over to "luci_deploy". Along the way, do a little cleanup, and split the AppEngine-centric code off from deployment-centric code. BUG=chromium:639981 TEST=None Committed: https://github.com/luci/luci-go/commit/557281dad2980196744d19babd69da1345b912fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -425 lines) Patch
M deploytool/api/deploy/component.proto View 1 chunk +13 lines, -0 lines 0 comments Download
M deploytool/api/deploy/component.pb.go View 3 chunks +163 lines, -143 lines 0 comments Download
M deploytool/api/deploy/util.go View 3 chunks +23 lines, -1 line 0 comments Download
A deploytool/cmd/luci_deploy/appengine.go View 1 chunk +337 lines, -0 lines 0 comments Download
M deploytool/cmd/luci_deploy/deploy_appengine.go View 1 chunk +0 lines, -280 lines 0 comments Download
M deploytool/cmd/luci_deploy/layout.go View 1 chunk +12 lines, -0 lines 0 comments Download
M deploytool/cmd/luci_deploy/path.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dnj
4 years ago (2016-12-17 08:54:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
557281dad2980196744d19babd69da1345b912fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698