OLD | NEW |
1 // Copyright 2016 the V8 project authors. All rights reserved. | 1 // Copyright 2016 the V8 project authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "src/wasm/wasm-macro-gen.h" | 5 #include "src/wasm/wasm-macro-gen.h" |
6 | 6 |
7 #include "test/cctest/cctest.h" | 7 #include "test/cctest/cctest.h" |
8 #include "test/cctest/compiler/value-helper.h" | 8 #include "test/cctest/compiler/value-helper.h" |
9 #include "test/cctest/wasm/wasm-run-utils.h" | 9 #include "test/cctest/wasm/wasm-run-utils.h" |
10 | 10 |
11 using namespace v8::base; | 11 using namespace v8::base; |
12 using namespace v8::internal; | 12 using namespace v8::internal; |
13 using namespace v8::internal::compiler; | 13 using namespace v8::internal::compiler; |
14 using namespace v8::internal::wasm; | 14 using namespace v8::internal::wasm; |
15 | 15 |
| 16 namespace { |
| 17 |
| 18 typedef float (*FloatBinOp)(float, float); |
| 19 typedef int32_t (*Int32BinOp)(int32_t, int32_t); |
| 20 |
| 21 template <typename T> |
| 22 T Add(T a, T b) { |
| 23 return a + b; |
| 24 } |
| 25 |
| 26 template <typename T> |
| 27 T Sub(T a, T b) { |
| 28 return a - b; |
| 29 } |
| 30 |
| 31 template <typename T> |
| 32 int32_t Equal(T a, T b) { |
| 33 return a == b ? 0xFFFFFFFF : 0; |
| 34 } |
| 35 |
| 36 template <typename T> |
| 37 int32_t NotEqual(T a, T b) { |
| 38 return a != b ? 0xFFFFFFFF : 0; |
| 39 } |
| 40 |
| 41 } // namespace |
| 42 |
16 // TODO(gdeepti): These are tests using sample values to verify functional | 43 // TODO(gdeepti): These are tests using sample values to verify functional |
17 // correctness of opcodes, add more tests for a range of values and macroize | 44 // correctness of opcodes, add more tests for a range of values and macroize |
18 // tests. | 45 // tests. |
19 | 46 |
| 47 // TODO(bbudge) Figure out how to compare floats in Wasm code that can handle |
| 48 // NaNs. For now, our tests avoid using NaNs. |
20 #define WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lane_value, lane_index) \ | 49 #define WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lane_value, lane_index) \ |
21 WASM_IF(WASM_##LANE_TYPE##_NE(WASM_GET_LOCAL(lane_value), \ | 50 WASM_IF(WASM_##LANE_TYPE##_NE(WASM_GET_LOCAL(lane_value), \ |
22 WASM_SIMD_##TYPE##_EXTRACT_LANE( \ | 51 WASM_SIMD_##TYPE##_EXTRACT_LANE( \ |
23 lane_index, WASM_GET_LOCAL(value))), \ | 52 lane_index, WASM_GET_LOCAL(value))), \ |
24 WASM_RETURN1(WASM_ZERO)) | 53 WASM_RETURN1(WASM_ZERO)) |
25 | 54 |
26 #define WASM_SIMD_CHECK4(TYPE, value, LANE_TYPE, lv0, lv1, lv2, lv3) \ | 55 #define WASM_SIMD_CHECK4(TYPE, value, LANE_TYPE, lv0, lv1, lv2, lv3) \ |
27 WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv0, 0) \ | 56 WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv0, 0) \ |
28 , WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv1, 1), \ | 57 , WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv1, 1), \ |
29 WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv2, 2), \ | 58 WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv2, 2), \ |
30 WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv3, 3) | 59 WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lv3, 3) |
31 | 60 |
32 #define WASM_SIMD_CHECK_SPLAT4(TYPE, value, LANE_TYPE, lv) \ | 61 #define WASM_SIMD_CHECK_SPLAT4(TYPE, value, LANE_TYPE, lv) \ |
33 WASM_SIMD_CHECK4(TYPE, value, LANE_TYPE, lv, lv, lv, lv) | 62 WASM_SIMD_CHECK4(TYPE, value, LANE_TYPE, lv, lv, lv, lv) |
34 | 63 |
| 64 #define WASM_SIMD_CHECK_F32_LANE(TYPE, value, lane_value, lane_index) \ |
| 65 WASM_IF( \ |
| 66 WASM_I32_NE(WASM_I32_REINTERPRET_F32(WASM_GET_LOCAL(lane_value)), \ |
| 67 WASM_I32_REINTERPRET_F32(WASM_SIMD_##TYPE##_EXTRACT_LANE( \ |
| 68 lane_index, WASM_GET_LOCAL(value)))), \ |
| 69 WASM_RETURN1(WASM_ZERO)) |
| 70 |
| 71 #define WASM_SIMD_CHECK4_F32(TYPE, value, lv0, lv1, lv2, lv3) \ |
| 72 WASM_SIMD_CHECK_F32_LANE(TYPE, value, lv0, 0) \ |
| 73 , WASM_SIMD_CHECK_F32_LANE(TYPE, value, lv1, 1), \ |
| 74 WASM_SIMD_CHECK_F32_LANE(TYPE, value, lv2, 2), \ |
| 75 WASM_SIMD_CHECK_F32_LANE(TYPE, value, lv3, 3) |
| 76 |
| 77 #define WASM_SIMD_CHECK_SPLAT4_F32(TYPE, value, lv) \ |
| 78 WASM_SIMD_CHECK4_F32(TYPE, value, lv, lv, lv, lv) |
| 79 |
| 80 #if V8_TARGET_ARCH_ARM |
| 81 WASM_EXEC_TEST(F32x4Splat) { |
| 82 FLAG_wasm_simd_prototype = true; |
| 83 |
| 84 WasmRunner<int32_t, float> r(kExecuteCompiled); |
| 85 byte lane_val = 0; |
| 86 byte simd = r.AllocateLocal(kAstS128); |
| 87 BUILD(r, WASM_BLOCK(WASM_SET_LOCAL(simd, WASM_SIMD_F32x4_SPLAT( |
| 88 WASM_GET_LOCAL(lane_val))), |
| 89 WASM_SIMD_CHECK_SPLAT4_F32(F32x4, simd, lane_val), |
| 90 WASM_RETURN1(WASM_ONE))); |
| 91 |
| 92 FOR_FLOAT32_INPUTS(i) { CHECK_EQ(1, r.Call(*i)); } |
| 93 } |
| 94 |
| 95 WASM_EXEC_TEST(F32x4ReplaceLane) { |
| 96 FLAG_wasm_simd_prototype = true; |
| 97 WasmRunner<int32_t, float, float> r(kExecuteCompiled); |
| 98 byte old_val = 0; |
| 99 byte new_val = 1; |
| 100 byte simd = r.AllocateLocal(kAstS128); |
| 101 BUILD(r, WASM_BLOCK( |
| 102 WASM_SET_LOCAL(simd, |
| 103 WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(old_val))), |
| 104 WASM_SET_LOCAL( |
| 105 simd, WASM_SIMD_F32x4_REPLACE_LANE(0, WASM_GET_LOCAL(simd), |
| 106 WASM_GET_LOCAL(new_val))), |
| 107 WASM_SIMD_CHECK4(F32x4, simd, F32, new_val, old_val, old_val, |
| 108 old_val), |
| 109 WASM_SET_LOCAL( |
| 110 simd, WASM_SIMD_F32x4_REPLACE_LANE(1, WASM_GET_LOCAL(simd), |
| 111 WASM_GET_LOCAL(new_val))), |
| 112 WASM_SIMD_CHECK4(F32x4, simd, F32, new_val, new_val, old_val, |
| 113 old_val), |
| 114 WASM_SET_LOCAL( |
| 115 simd, WASM_SIMD_F32x4_REPLACE_LANE(2, WASM_GET_LOCAL(simd), |
| 116 WASM_GET_LOCAL(new_val))), |
| 117 WASM_SIMD_CHECK4(F32x4, simd, F32, new_val, new_val, new_val, |
| 118 old_val), |
| 119 WASM_SET_LOCAL( |
| 120 simd, WASM_SIMD_F32x4_REPLACE_LANE(3, WASM_GET_LOCAL(simd), |
| 121 WASM_GET_LOCAL(new_val))), |
| 122 WASM_SIMD_CHECK_SPLAT4(F32x4, simd, F32, new_val), |
| 123 WASM_RETURN1(WASM_ONE))); |
| 124 |
| 125 CHECK_EQ(1, r.Call(3.14159, -1.5)); |
| 126 } |
| 127 |
| 128 // Tests both signed and unsigned conversion. |
| 129 WASM_EXEC_TEST(F32x4FromInt32x4) { |
| 130 FLAG_wasm_simd_prototype = true; |
| 131 WasmRunner<int32_t, int32_t, float, float> r(kExecuteCompiled); |
| 132 byte a = 0; |
| 133 byte expected_signed = 1; |
| 134 byte expected_unsigned = 2; |
| 135 byte simd0 = r.AllocateLocal(kAstS128); |
| 136 byte simd1 = r.AllocateLocal(kAstS128); |
| 137 byte simd2 = r.AllocateLocal(kAstS128); |
| 138 BUILD(r, WASM_BLOCK( |
| 139 WASM_SET_LOCAL(simd0, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(a))), |
| 140 WASM_SET_LOCAL( |
| 141 simd1, WASM_SIMD_F32x4_FROM_I32x4(WASM_GET_LOCAL(simd0))), |
| 142 WASM_SIMD_CHECK_SPLAT4_F32(F32x4, simd1, expected_signed), |
| 143 WASM_SET_LOCAL( |
| 144 simd2, WASM_SIMD_F32x4_FROM_U32x4(WASM_GET_LOCAL(simd0))), |
| 145 WASM_SIMD_CHECK_SPLAT4_F32(F32x4, simd2, expected_unsigned), |
| 146 WASM_RETURN1(WASM_ONE))); |
| 147 |
| 148 FOR_INT32_INPUTS(i) { |
| 149 CHECK_EQ(1, r.Call(*i, static_cast<float>(*i), |
| 150 static_cast<float>(static_cast<uint32_t>(*i)))); |
| 151 } |
| 152 } |
| 153 |
| 154 WASM_EXEC_TEST(S32x4Select) { |
| 155 FLAG_wasm_simd_prototype = true; |
| 156 WasmRunner<int32_t, int32_t, int32_t> r(kExecuteCompiled); |
| 157 byte val1 = 0; |
| 158 byte val2 = 1; |
| 159 byte mask = r.AllocateLocal(kAstS128); |
| 160 byte src1 = r.AllocateLocal(kAstS128); |
| 161 byte src2 = r.AllocateLocal(kAstS128); |
| 162 BUILD(r, |
| 163 WASM_BLOCK( |
| 164 WASM_SET_LOCAL(mask, WASM_SIMD_I32x4_SPLAT(WASM_ZERO)), |
| 165 WASM_SET_LOCAL(src1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(val1))), |
| 166 WASM_SET_LOCAL(src2, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(val2))), |
| 167 WASM_SET_LOCAL(mask, WASM_SIMD_I32x4_REPLACE_LANE( |
| 168 1, WASM_GET_LOCAL(mask), WASM_I32V(-1))), |
| 169 WASM_SET_LOCAL(mask, WASM_SIMD_I32x4_REPLACE_LANE( |
| 170 2, WASM_GET_LOCAL(mask), WASM_I32V(-1))), |
| 171 WASM_SET_LOCAL(mask, WASM_SIMD_S32x4_SELECT(WASM_GET_LOCAL(mask), |
| 172 WASM_GET_LOCAL(src1), |
| 173 WASM_GET_LOCAL(src2))), |
| 174 WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val2, 0), |
| 175 WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val1, 1), |
| 176 WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val1, 2), |
| 177 WASM_SIMD_CHECK_LANE(I32x4, mask, I32, val2, 3), |
| 178 WASM_RETURN1(WASM_ONE))); |
| 179 |
| 180 CHECK_EQ(1, r.Call(0x1234, 0x5678)); |
| 181 } |
| 182 |
| 183 static void RunF32x4BinopTest(WasmOpcode simd_op, FloatBinOp expected_op) { |
| 184 FLAG_wasm_simd_prototype = true; |
| 185 WasmRunner<int32_t, float, float, float> r(kExecuteCompiled); |
| 186 byte a = 0; |
| 187 byte b = 1; |
| 188 byte expected = 2; |
| 189 byte simd0 = r.AllocateLocal(kAstS128); |
| 190 byte simd1 = r.AllocateLocal(kAstS128); |
| 191 BUILD(r, WASM_BLOCK( |
| 192 WASM_SET_LOCAL(simd0, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(a))), |
| 193 WASM_SET_LOCAL(simd1, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(b))), |
| 194 WASM_SET_LOCAL(simd1, WASM_SIMD_BINOP(simd_op & 0xffu, |
| 195 WASM_GET_LOCAL(simd0), |
| 196 WASM_GET_LOCAL(simd1))), |
| 197 WASM_SIMD_CHECK_SPLAT4_F32(F32x4, simd1, expected), |
| 198 WASM_RETURN1(WASM_ONE))); |
| 199 |
| 200 FOR_FLOAT32_INPUTS(i) { |
| 201 if (std::isnan(*i)) continue; |
| 202 FOR_FLOAT32_INPUTS(j) { |
| 203 if (std::isnan(*j)) continue; |
| 204 CHECK_EQ(1, r.Call(*i, *j, expected_op(*i, *j))); |
| 205 } |
| 206 } |
| 207 } |
| 208 |
| 209 WASM_EXEC_TEST(F32x4Add) { RunF32x4BinopTest(kExprF32x4Add, Add); } |
| 210 WASM_EXEC_TEST(F32x4Sub) { RunF32x4BinopTest(kExprF32x4Sub, Sub); } |
| 211 #endif // V8_TARGET_ARCH_ARM |
| 212 |
35 WASM_EXEC_TEST(I32x4Splat) { | 213 WASM_EXEC_TEST(I32x4Splat) { |
36 FLAG_wasm_simd_prototype = true; | 214 FLAG_wasm_simd_prototype = true; |
37 | 215 |
38 // Store SIMD value in a local variable, use extract lane to check lane values | 216 // Store SIMD value in a local variable, use extract lane to check lane values |
39 // This test is not a test for ExtractLane as Splat does not create | 217 // This test is not a test for ExtractLane as Splat does not create |
40 // interesting SIMD values. | 218 // interesting SIMD values. |
41 // | 219 // |
42 // SetLocal(1, I32x4Splat(Local(0))); | 220 // SetLocal(1, I32x4Splat(Local(0))); |
43 // For each lane index | 221 // For each lane index |
44 // if(Local(0) != I32x4ExtractLane(Local(1), index) | 222 // if(Local(0) != I32x4ExtractLane(Local(1), index) |
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
82 old_val), | 260 old_val), |
83 WASM_SET_LOCAL( | 261 WASM_SET_LOCAL( |
84 simd, WASM_SIMD_I32x4_REPLACE_LANE(3, WASM_GET_LOCAL(simd), | 262 simd, WASM_SIMD_I32x4_REPLACE_LANE(3, WASM_GET_LOCAL(simd), |
85 WASM_GET_LOCAL(new_val))), | 263 WASM_GET_LOCAL(new_val))), |
86 WASM_SIMD_CHECK_SPLAT4(I32x4, simd, I32, new_val), | 264 WASM_SIMD_CHECK_SPLAT4(I32x4, simd, I32, new_val), |
87 WASM_RETURN1(WASM_ONE))); | 265 WASM_RETURN1(WASM_ONE))); |
88 | 266 |
89 CHECK_EQ(1, r.Call(1, 2)); | 267 CHECK_EQ(1, r.Call(1, 2)); |
90 } | 268 } |
91 | 269 |
92 WASM_EXEC_TEST(I32x4Add) { | 270 #if V8_TARGET_ARCH_ARM |
| 271 |
| 272 // Determines if conversion from float to int will be valid. |
| 273 bool CanRoundToZeroAndConvert(double val, bool unsigned_integer) { |
| 274 const double max_uint = static_cast<double>(0xffffffffu); |
| 275 const double max_int = static_cast<double>(kMaxInt); |
| 276 const double min_int = static_cast<double>(kMinInt); |
| 277 |
| 278 // Check for NaN. |
| 279 if (val != val) { |
| 280 return false; |
| 281 } |
| 282 |
| 283 // Round to zero and check for overflow. This code works because 32 bit |
| 284 // integers can be exactly represented by ieee-754 64bit floating-point |
| 285 // values. |
| 286 return unsigned_integer ? (val < (max_uint + 1.0)) && (val > -1) |
| 287 : (val < (max_int + 1.0)) && (val > (min_int - 1.0)); |
| 288 } |
| 289 |
| 290 int ConvertInvalidValue(double val, bool unsigned_integer) { |
| 291 if (val != val) { |
| 292 return 0; |
| 293 } else { |
| 294 if (unsigned_integer) { |
| 295 return (val < 0) ? 0 : 0xffffffffu; |
| 296 } else { |
| 297 return (val < 0) ? kMinInt : kMaxInt; |
| 298 } |
| 299 } |
| 300 } |
| 301 |
| 302 int32_t ConvertToInt(double val, bool unsigned_integer) { |
| 303 int32_t result = |
| 304 unsigned_integer ? static_cast<uint32_t>(val) : static_cast<int32_t>(val); |
| 305 |
| 306 if (!CanRoundToZeroAndConvert(val, unsigned_integer)) { |
| 307 result = ConvertInvalidValue(val, unsigned_integer); |
| 308 } |
| 309 return result; |
| 310 } |
| 311 |
| 312 // Tests both signed and unsigned conversion. |
| 313 WASM_EXEC_TEST(I32x4FromFloat32x4) { |
| 314 FLAG_wasm_simd_prototype = true; |
| 315 WasmRunner<int32_t, float, int32_t, int32_t> r(kExecuteCompiled); |
| 316 byte a = 0; |
| 317 byte expected_signed = 1; |
| 318 byte expected_unsigned = 2; |
| 319 byte simd0 = r.AllocateLocal(kAstS128); |
| 320 byte simd1 = r.AllocateLocal(kAstS128); |
| 321 byte simd2 = r.AllocateLocal(kAstS128); |
| 322 BUILD(r, WASM_BLOCK( |
| 323 WASM_SET_LOCAL(simd0, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(a))), |
| 324 WASM_SET_LOCAL( |
| 325 simd1, WASM_SIMD_I32x4_FROM_F32x4(WASM_GET_LOCAL(simd0))), |
| 326 WASM_SIMD_CHECK_SPLAT4(I32x4, simd1, I32, expected_signed), |
| 327 WASM_SET_LOCAL( |
| 328 simd2, WASM_SIMD_U32x4_FROM_F32x4(WASM_GET_LOCAL(simd0))), |
| 329 WASM_SIMD_CHECK_SPLAT4(I32x4, simd2, I32, expected_unsigned), |
| 330 WASM_RETURN1(WASM_ONE))); |
| 331 |
| 332 FOR_FLOAT32_INPUTS(i) { |
| 333 int32_t signed_value = ConvertToInt(*i, false); |
| 334 int32_t unsigned_value = ConvertToInt(*i, true); |
| 335 CHECK_EQ(1, r.Call(*i, signed_value, unsigned_value)); |
| 336 } |
| 337 } |
| 338 #endif // V8_TARGET_ARCH_ARM |
| 339 |
| 340 static void RunI32x4BinopTest(WasmOpcode simd_op, Int32BinOp expected_op) { |
93 FLAG_wasm_simd_prototype = true; | 341 FLAG_wasm_simd_prototype = true; |
94 WasmRunner<int32_t, int32_t, int32_t, int32_t> r(kExecuteCompiled); | 342 WasmRunner<int32_t, int32_t, int32_t, int32_t> r(kExecuteCompiled); |
95 byte a = 0; | 343 byte a = 0; |
96 byte b = 1; | |
97 byte expected = 2; | |
98 byte simd0 = r.AllocateLocal(kAstS128); | |
99 byte simd1 = r.AllocateLocal(kAstS128); | |
100 BUILD(r, | |
101 WASM_BLOCK( | |
102 WASM_SET_LOCAL(simd0, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(a))), | |
103 WASM_SET_LOCAL(simd1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(b))), | |
104 WASM_SET_LOCAL(simd1, WASM_SIMD_I32x4_ADD(WASM_GET_LOCAL(simd0), | |
105 WASM_GET_LOCAL(simd1))), | |
106 WASM_SIMD_CHECK_SPLAT4(I32x4, simd1, I32, expected), | |
107 WASM_RETURN1(WASM_ONE))); | |
108 | |
109 FOR_INT32_INPUTS(i) { | |
110 FOR_INT32_INPUTS(j) { CHECK_EQ(1, r.Call(*i, *j, *i + *j)); } | |
111 } | |
112 } | |
113 | |
114 WASM_EXEC_TEST(I32x4Sub) { | |
115 FLAG_wasm_simd_prototype = true; | |
116 WasmRunner<int32_t, int32_t, int32_t, int32_t> r(kExecuteCompiled); | |
117 byte a = 0; | |
118 byte b = 1; | 344 byte b = 1; |
119 byte expected = 2; | 345 byte expected = 2; |
120 byte simd0 = r.AllocateLocal(kAstS128); | 346 byte simd0 = r.AllocateLocal(kAstS128); |
121 byte simd1 = r.AllocateLocal(kAstS128); | 347 byte simd1 = r.AllocateLocal(kAstS128); |
122 BUILD(r, | 348 BUILD(r, WASM_BLOCK( |
123 WASM_BLOCK( | 349 WASM_SET_LOCAL(simd0, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(a))), |
124 WASM_SET_LOCAL(simd0, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(a))), | 350 WASM_SET_LOCAL(simd1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(b))), |
125 WASM_SET_LOCAL(simd1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(b))), | 351 WASM_SET_LOCAL(simd1, WASM_SIMD_BINOP(simd_op & 0xffu, |
126 WASM_SET_LOCAL(simd1, WASM_SIMD_I32x4_SUB(WASM_GET_LOCAL(simd0), | 352 WASM_GET_LOCAL(simd0), |
127 WASM_GET_LOCAL(simd1))), | 353 WASM_GET_LOCAL(simd1))), |
128 WASM_SIMD_CHECK_SPLAT4(I32x4, simd1, I32, expected), | 354 WASM_SIMD_CHECK_SPLAT4(I32x4, simd1, I32, expected), |
129 WASM_RETURN1(WASM_ONE))); | 355 WASM_RETURN1(WASM_ONE))); |
130 | 356 |
131 FOR_INT32_INPUTS(i) { | 357 FOR_INT32_INPUTS(i) { |
132 FOR_INT32_INPUTS(j) { CHECK_EQ(1, r.Call(*i, *j, *i - *j)); } | 358 FOR_INT32_INPUTS(j) { CHECK_EQ(1, r.Call(*i, *j, expected_op(*i, *j))); } |
133 } | 359 } |
134 } | 360 } |
| 361 |
| 362 WASM_EXEC_TEST(I32x4Add) { RunI32x4BinopTest(kExprI32x4Add, Add); } |
| 363 |
| 364 WASM_EXEC_TEST(I32x4Sub) { RunI32x4BinopTest(kExprI32x4Sub, Sub); } |
| 365 |
| 366 #if V8_TARGET_ARCH_ARM |
| 367 WASM_EXEC_TEST(I32x4Equal) { RunI32x4BinopTest(kExprI32x4Eq, Equal); } |
| 368 |
| 369 WASM_EXEC_TEST(I32x4NotEqual) { RunI32x4BinopTest(kExprI32x4Ne, NotEqual); } |
| 370 #endif // V8_TARGET_ARCH_ARM |
OLD | NEW |