Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 258483002: Revert of MacViews: Better layering for the touch selection controller (Closed)

Created:
6 years, 8 months ago by Vadim Sh.
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Visibility:
Public.

Description

Revert of MacViews: Better layering for the touch selection controller (https://codereview.chromium.org/248763003/) Reason for revert: Failed to compile on ChromiumOS Linux: ./../ui/views/touchui/touch_selection_controller_impl_unittest.cc:20:57: fatal error: ui/views/touch_selection_controller_factory.h: No such file or directory compilation terminated. See http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/2921. Original issue's description: > MacViews: Better layering for the touch selection controller > > This CL moves ViewsTouchSelectionControllerFactory out of > views/touchui/touch_selection_controller_impl.cc and into its own file > one level higher. > > Result: the single touchui dependency moves from views_delegate.cc to a > file that can be controlled on a per-platform basis. The touchui > subfolder assumes aura is available. This allows touchui to be excluded > from a build that doesn't need it. > > BUG=366007 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265814 TBR=ben@chromium.org,tapted@chromium.org NOTREECHECKS=true NOTRY=true BUG=366007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -70 lines) Patch
M ui/views/touchui/touch_selection_controller_impl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/views_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ui/views/views_touch_selection_controller_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/views/views_touch_selection_controller_factory_aura.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/views/views_touch_selection_controller_factory_mac.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vadim Sh.
Created Revert of MacViews: Better layering for the touch selection controller
6 years, 8 months ago (2014-04-24 01:58:05 UTC) #1
Vadim Sh.
The CQ bit was unchecked by vadimsh@chromium.org
6 years, 8 months ago (2014-04-24 02:08:23 UTC) #2
Vadim Sh.
6 years, 8 months ago (2014-04-24 02:08:41 UTC) #3
On 2014/04/24 01:58:05, Vadim Sh. wrote:
> Created Revert of MacViews: Better layering for the touch selection controller

CQ is not picking this up for some reason. I'll use drover instead.

Powered by Google App Engine
This is Rietveld 408576698