Issue 2584743002: Fix SharedSampler to cope correctly with zero-thread processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2584743002: Fix SharedSampler to cope correctly with zero-thread processes. (Closed)

Created:
4 years ago by Wez

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Fix SharedSampler to cope correctly with zero-thread processes. SharedSampler previously assumed that all processes have at least one thread, which appears no longer to be the case for the Windows operating system's "System and Compressed Memory" process. BUG=673175 Review-Url: https://codereview.chromium.org/2566423002 Cr-Commit-Position: refs/heads/master@{#438322} (cherry picked from commit 8c4cfd4e82b4465305d60d3830bcbae50076f004) Committed: https://chromium.googlesource.com/chromium/src/+/962230afbdb5e107d5b5f65c94fd520783f25ab6

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/task_manager/sampling/shared_sampler_win.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Wez

4 years ago (2016-12-15 23:47:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
962230afbdb5e107d5b5f65c94fd520783f25ab6.