Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: third_party/WebKit/Source/core/timing/Performance.cpp

Issue 2584733003: Remove performanceMonitor()->unsubscribeAll() from Performance's destructor (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/timing/Performance.cpp
diff --git a/third_party/WebKit/Source/core/timing/Performance.cpp b/third_party/WebKit/Source/core/timing/Performance.cpp
index abae0a17e72d92f137232a2230b0c36c2ba35712..5e513e6222e76e7e611f693fa199918c621d77f5 100644
--- a/third_party/WebKit/Source/core/timing/Performance.cpp
+++ b/third_party/WebKit/Source/core/timing/Performance.cpp
@@ -104,8 +104,9 @@ Performance::Performance(LocalFrame* frame)
ContextLifecycleObserver(frame ? frame->document() : nullptr) {}
Performance::~Performance() {
- if (frame())
- frame()->performanceMonitor()->unsubscribeAll(this);
+ // contextDestryoed() should have been called and the performance
+ // monitors should have been unsubscribed.
+ DCHECK(!frame());
}
void Performance::contextDestroyed() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698