Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: src/arraybuffer.js

Issue 258473004: Harden more runtime functions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 22 matching lines...) Expand all
33 33
34 function ArrayBufferConstructor(length) { // length = 1 34 function ArrayBufferConstructor(length) { // length = 1
35 if (%_IsConstructCall()) { 35 if (%_IsConstructCall()) {
36 var byteLength = ToPositiveInteger(length, 'invalid_array_buffer_length'); 36 var byteLength = ToPositiveInteger(length, 'invalid_array_buffer_length');
37 %ArrayBufferInitialize(this, byteLength); 37 %ArrayBufferInitialize(this, byteLength);
38 } else { 38 } else {
39 throw MakeTypeError('constructor_not_function', ["ArrayBuffer"]); 39 throw MakeTypeError('constructor_not_function', ["ArrayBuffer"]);
40 } 40 }
41 } 41 }
42 42
43 function ArrayBufferGetByteLength() { 43 function ArrayBufferGetByteLen() {
44 if (!IS_ARRAYBUFFER(this)) { 44 if (!IS_ARRAYBUFFER(this)) {
45 throw MakeTypeError('incompatible_method_receiver', 45 throw MakeTypeError('incompatible_method_receiver',
46 ['ArrayBuffer.prototype.byteLength', this]); 46 ['ArrayBuffer.prototype.byteLength', this]);
47 } 47 }
48 return %_ArrayBufferGetByteLength(this); 48 return %_ArrayBufferGetByteLength(this);
49 } 49 }
50 50
51 // ES6 Draft 15.13.5.5.3 51 // ES6 Draft 15.13.5.5.3
52 function ArrayBufferSlice(start, end) { 52 function ArrayBufferSlice(start, end) {
53 if (!IS_ARRAYBUFFER(this)) { 53 if (!IS_ARRAYBUFFER(this)) {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 function SetUpArrayBuffer() { 92 function SetUpArrayBuffer() {
93 %CheckIsBootstrapping(); 93 %CheckIsBootstrapping();
94 94
95 // Set up the ArrayBuffer constructor function. 95 // Set up the ArrayBuffer constructor function.
96 %SetCode($ArrayBuffer, ArrayBufferConstructor); 96 %SetCode($ArrayBuffer, ArrayBufferConstructor);
97 %FunctionSetPrototype($ArrayBuffer, new $Object()); 97 %FunctionSetPrototype($ArrayBuffer, new $Object());
98 98
99 // Set up the constructor property on the ArrayBuffer prototype object. 99 // Set up the constructor property on the ArrayBuffer prototype object.
100 %SetProperty($ArrayBuffer.prototype, "constructor", $ArrayBuffer, DONT_ENUM); 100 %SetProperty($ArrayBuffer.prototype, "constructor", $ArrayBuffer, DONT_ENUM);
101 101
102 InstallGetter($ArrayBuffer.prototype, "byteLength", ArrayBufferGetByteLength); 102 InstallGetter($ArrayBuffer.prototype, "byteLength", ArrayBufferGetByteLen);
103 103
104 InstallFunctions($ArrayBuffer, DONT_ENUM, $Array( 104 InstallFunctions($ArrayBuffer, DONT_ENUM, $Array(
105 "isView", ArrayBufferIsView 105 "isView", ArrayBufferIsView
106 )); 106 ));
107 107
108 InstallFunctions($ArrayBuffer.prototype, DONT_ENUM, $Array( 108 InstallFunctions($ArrayBuffer.prototype, DONT_ENUM, $Array(
109 "slice", ArrayBufferSlice 109 "slice", ArrayBufferSlice
110 )); 110 ));
111 } 111 }
112 112
113 SetUpArrayBuffer(); 113 SetUpArrayBuffer();
OLDNEW
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698