Harden more runtime functions.

Harden more runtime functions.

R=dslomov@chromium.org, dslomov@google.com

Committed: https://code.google.com/p/v8/source/detail?r=20936

[Jakob Kummerow, 2014-04-24 09:01:33]

PTAL.

The renaming of that builtin is not strictly necessary, it's just to avoid
clashing with the runtime function of the same name ("%Foo()" happily tries to
call a builtin Foo() instead of Runtime_Foo()).

Next up: test case generator.

[Dmitry Lomov (no reviews), 2014-04-24 09:24:58]

lgtm with comments

https://codereview.chromium.org/258473004/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/258473004/diff/1/src/runtime.cc#newcode1283
src/runtime.cc:1283: RUNTIME_ASSERT(buffer_length - length >= offset);
Add buffer_length >= length here

https://codereview.chromium.org/258473004/diff/1/src/runtime.cc#newcode9680
src/runtime.cc:9680: FixedArray* output_array =
FixedArray::cast(output->elements());
nit: use handle here since this is now out of DisallowHeapAllocation scope

[Jakob Kummerow, 2014-04-24 10:58:26]

https://codereview.chromium.org/258473004/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/258473004/diff/1/src/runtime.cc#newcode1283
src/runtime.cc:1283: RUNTIME_ASSERT(buffer_length - length >= offset);
On 2014/04/24 09:24:59, Dmitry Lomov (chromium) wrote:
> Add buffer_length >= length here

Done.

https://codereview.chromium.org/258473004/diff/1/src/runtime.cc#newcode9680
src/runtime.cc:9680: FixedArray* output_array =
FixedArray::cast(output->elements());
On 2014/04/24 09:24:59, Dmitry Lomov (chromium) wrote:
> nit: use handle here since this is now out of DisallowHeapAllocation scope

Done.

[Dmitry Lomov, 2014-04-24 11:01:58]

lgtm

[Jakob Kummerow, 2014-04-24 11:11:47]

Committed patchset #2 manually as r20936 (presubmit successful).