Add simple PRESUBMIT check to ensure that all files ending with .json can

Add simple PRESUBMIT check to ensure that all files ending with .json can
be loaded as json.

R=jochen@chromium.org, maruel@chromium.org
BUG=366395
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265881

[iannucci, 2014-04-24 00:31:38]

PTAL :)

[M-A Ruel, 2014-04-24 00:32:49]

https://codereview.chromium.org/258473002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/258473002/diff/1/PRESUBMIT.py#newcode12
PRESUBMIT.py:12: import json
not needed

https://codereview.chromium.org/258473002/diff/1/PRESUBMIT.py#newcode1069
PRESUBMIT.py:1069: for fpath in input_api.AffectedFiles(file_filter=
file_filter):
remove space

https://codereview.chromium.org/258473002/diff/1/PRESUBMIT.py#newcode1072
PRESUBMIT.py:1072: json.load(f)
input_api.json.load(f)

[iannucci, 2014-04-24 00:36:20]

PTAL

https://chromiumcodereview.appspot.com/258473002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/258473002/diff/1/PRESUBMIT.py#newcode1069
PRESUBMIT.py:1069: for fpath in input_api.AffectedFiles(file_filter=
file_filter):
On 2014/04/24 00:32:50, M-A Ruel wrote:
> remove space

Oops, Done.

https://chromiumcodereview.appspot.com/258473002/diff/1/PRESUBMIT.py#newcode1072
PRESUBMIT.py:1072: json.load(f)
On 2014/04/24 00:32:50, M-A Ruel wrote:
> input_api.json.load(f)

Done.

[M-A Ruel, 2014-04-24 00:37:30]

lgtm

[iannucci, 2014-04-24 00:39:04]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-04-24 00:40:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/258473002/20001

[commit-bot: I haz the power, 2014-04-24 01:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 01:18:44]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[iannucci, 2014-04-24 01:31:44]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-04-24 01:59:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/258473002/20001

[commit-bot: I haz the power, 2014-04-24 03:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 03:34:07]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[iannucci, 2014-04-24 03:36:17]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-04-24 03:36:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/258473002/20001

[commit-bot: I haz the power, 2014-04-24 04:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 04:16:48]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[iannucci, 2014-04-24 04:30:23]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2014-04-24 04:52:57]

The CQ bit was unchecked by iannucci@chromium.org

[iannucci, 2014-04-24 04:53:07]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-04-24 04:57:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/258473002/20001

[iannucci, 2014-04-24 07:20:30]

The CQ bit was unchecked by iannucci@chromium.org

[iannucci, 2014-04-24 07:20:38]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-04-24 08:25:27]

Change committed as 265881

[Yoyo Zhou, 2014-04-24 19:40:09]

I tripped over this change today because it doesn't deal with comments in the
JSON (e.g. copyright headers). So, for example, any changes to
chrome/common/extensions/_api_features.json is treated as invalid. In practice,
these comments are stripped out by a JSON preprocessor 
(see JSONParser::EatWhitespaceAndComments in C++, or json_comment_eater.py in
python).

I have this pending CL which I think handles it better, and includes unit tests:

https://codereview.chromium.org/239283008/

[Yoyo Zhou, 2014-04-24 20:19:19]

A revert of this CL has been created in
https://codereview.chromium.org/251443005/ by yoz@chromium.org.

The reason for reverting is: This presubmit rejects existing .json files in the
tree that contain comments.
(It also doesn't provide enough information about where the json is invalid.).