Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h

Issue 2584653002: Force subtree paint property updates on local border box changes (Closed)
Patch Set: fix bugs Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
index 0204844235482c817b3b3089078fd63d1a110951..6c96366ee0791e2556e9b55a514060a071d7fa25 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
@@ -15,9 +15,7 @@
namespace blink {
// A complete set of paint properties including those that are inherited from
-// other objects. RefPtrs are used to guard against use-after-free bugs and
-// DCHECKs ensure PropertyTreeState never retains the last reference to a
-// property tree node.
+// other objects. RefPtrs are only used to guard against use-after-free bugs.
class PropertyTreeState {
public:
PropertyTreeState(const TransformPaintPropertyNode* transform,
@@ -35,7 +33,6 @@ class PropertyTreeState {
}
const TransformPaintPropertyNode* transform() const {
- DCHECK(!m_transform || !m_transform->hasOneRef());
return m_transform.get();
}
void setTransform(const TransformPaintPropertyNode* node) {
@@ -44,7 +41,6 @@ class PropertyTreeState {
}
const ClipPaintPropertyNode* clip() const {
- DCHECK(!m_clip || !m_clip->hasOneRef());
return m_clip.get();
}
void setClip(const ClipPaintPropertyNode* node) {
@@ -53,7 +49,6 @@ class PropertyTreeState {
}
const EffectPaintPropertyNode* effect() const {
- DCHECK(!m_effect || !m_effect->hasOneRef());
return m_effect.get();
}
void setEffect(const EffectPaintPropertyNode* node) {
@@ -62,7 +57,6 @@ class PropertyTreeState {
}
const ScrollPaintPropertyNode* scroll() const {
- DCHECK(!m_scroll || !m_scroll->hasOneRef());
return m_scroll.get();
}
void setScroll(const ScrollPaintPropertyNode* node) {
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698