Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom

Issue 2584643002: Revamp OffscreenCanvas commit flow (Closed)
Patch Set: rebase and fix conflict Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/blink_typemaps.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
diff --git a/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom b/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
index f4e4448d561060e6fd9d53c0f2bae50a8f2d5c4e..ecc7f3d5a33a89def9db3e02700267de4de9d918 100644
--- a/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
+++ b/third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom
@@ -5,23 +5,33 @@
module blink.mojom;
import "cc/ipc/compositor_frame.mojom";
+import "cc/ipc/frame_sink_id.mojom";
import "cc/ipc/mojo_compositor_frame_sink.mojom";
import "cc/ipc/surface_id.mojom";
import "cc/ipc/surface_sequence.mojom";
interface OffscreenCanvasSurface {
- // TODO(619138): Make creation of surface id Async after implementation
- // change on surface_id generator that makes client side be able to generate
- // unique surface_id.id_namespace alone.
- [Sync]
- GetSurfaceId() => (cc.mojom.SurfaceId surface_id);
-
Require(cc.mojom.SurfaceId surface_id, cc.mojom.SurfaceSequence sequence);
Satisfy(cc.mojom.SurfaceSequence sequence);
};
+interface OffscreenCanvasSurfaceClient {
+ // TODO(fsamuel, xlai): Replace this with DisplayCompositorClient
+ OnSurfaceCreated(cc.mojom.SurfaceId surface_id,
+ int32 width,
+ int32 height,
+ float device_scale_factor);
+};
+
+interface OffscreenCanvasSurfaceFactory {
+ CreateOffscreenCanvasSurface(cc.mojom.FrameSinkId frame_sink_id,
+ OffscreenCanvasSurfaceClient client,
+ OffscreenCanvasSurface& service);
+};
+
interface OffscreenCanvasCompositorFrameSinkProvider {
- CreateCompositorFrameSink(cc.mojom.SurfaceId surface_id,
+ // TODO(fsamuel, xlai): Replace this with DisplayCompositor
+ CreateCompositorFrameSink(cc.mojom.FrameSinkId frame_sink_id,
cc.mojom.MojoCompositorFrameSinkClient client,
cc.mojom.MojoCompositorFrameSink& sink);
};
« no previous file with comments | « third_party/WebKit/public/blink_typemaps.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698