Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_manager.h

Issue 2584643002: Revamp OffscreenCanvas commit flow (Closed)
Patch Set: rebase and fix conflict Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_surface_manager.h
diff --git a/content/browser/renderer_host/offscreen_canvas_surface_manager.h b/content/browser/renderer_host/offscreen_canvas_surface_manager.h
index 3901bb4e7120283b43027623e11bfea0426acc9f..5b557ba6bb9fa1da6a7ef48655260cd7fc36f1d2 100644
--- a/content/browser/renderer_host/offscreen_canvas_surface_manager.h
+++ b/content/browser/renderer_host/offscreen_canvas_surface_manager.h
@@ -29,12 +29,9 @@ class CONTENT_EXPORT OffscreenCanvasSurfaceManager
friend class OffscreenCanvasSurfaceManagerTest;
// cc::SurfaceObserver implementation.
- // TODO(crbug.com/662498): Implement these functions when
- // OffscreenCanvasSurfaceManager must propagate the resizing information
- // back to renderer/main.
void OnSurfaceCreated(const cc::SurfaceId& surface_id,
const gfx::Size& frame_size,
- float device_scale_factor) override {}
+ float device_scale_factor) override;
void OnSurfaceDamaged(const cc::SurfaceId&, bool* changed) override {}
// When an OffscreenCanvasSurfaceImpl instance is destructed, it will

Powered by Google App Engine
This is Rietveld 408576698