Revamp OffscreenCanvas commit flow

third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/OffscreenCanvasFrameDispatcherImpl.h"
 
 #include "cc/output/compositor_frame.h"
 #include "cc/quads/texture_draw_quad.h"
 #include "gpu/command_buffer/client/gles2_interface.h"
 #include "platform/CrossThreadFunctional.h"
@@ skipping 12 matching lines @@
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/transform.h"
 #include "wtf/typed_arrays/ArrayBuffer.h"
 #include "wtf/typed_arrays/Uint8Array.h"
 
 namespace blink {
 
 OffscreenCanvasFrameDispatcherImpl::OffscreenCanvasFrameDispatcherImpl(
     uint32_t clientId,
     uint32_t sinkId,
-    uint32_t localId,
-    uint64_t nonceHigh,
-    uint64_t nonceLow,
     int canvasId,
     int width,
     int height)
-    : m_frameSinkId(cc::FrameSinkId(clientId, sinkId)),
-      m_currentLocalFrameId(cc::LocalFrameId(
-          localId,
-          base::UnguessableToken::Deserialize(nonceHigh, nonceLow))),
+    : m_surfaceIdAllocator(new cc::SurfaceIdAllocator()),

[Fady Samuel, 2016/12/15 19:54:52]

You don't need this on the heap, just make it inplace.

[xlai (Olivia), 2016/12/15 22:20:12]

Done.

+      m_frameSinkId(cc::FrameSinkId(clientId, sinkId)),
+      m_currentLocalFrameId(m_surfaceIdAllocator->GenerateId()),
       m_width(width),
       m_height(height),
       m_nextResourceId(1u),
       m_binding(this),
       m_placeholderCanvasId(canvasId) {
   DCHECK(!m_sink.is_bound());
   mojom::blink::OffscreenCanvasCompositorFrameSinkProviderPtr provider;
   Platform::current()->interfaceProvider()->getInterface(
       mojo::GetProxy(&provider));
   cc::SurfaceId surfaceId(m_frameSinkId, m_currentLocalFrameId);
@@ skipping 356 matching lines @@
     return true;
   return false;
 }
 
 void OffscreenCanvasFrameDispatcherImpl::reshape(int width, int height) {
   m_width = width;
   m_height = height;
 }
 
 }  // namespace blink