Issue 2584593002: Disable libraries_reader_test on dart2js for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2584593002: Disable libraries_reader_test on dart2js for now. (Closed)

Created:
4 years ago by Paul Berry

Modified:
4 years ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Disable libraries_reader_test on dart2js for now. The test has a transitive dependency on dart:io which I haven't quite figured out yet. Once I figure out how to remove the transitive dependency I'll re-enable the test. TBR=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/d8f75e8dcafc4e4c740bf645023b70c8a071f8b1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Paul Berry

4 years ago (2016-12-15 15:20:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d8f75e8dcafc4e4c740bf645023b70c8a071f8b1 (presubmit successful).