Split out non-auto-generatable externs from auto generated ones.

Split out non-auto-generatable externs from auto generated ones.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[David Tseng, 2016-12-15 22:34:03]

Description was changed from

==========
Split out non-auto-generatable externs from auto generated ones.

BUG=
==========

to

==========
Split out non-auto-generatable externs from auto generated ones.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-12-15 22:39:36]

Description was changed from

==========
Split out non-auto-generatable externs from auto generated ones.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Split out non-auto-generatable externs from auto generated ones.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-12-15 22:39:36]

dtseng@chromium.org changed reviewers:
+ dbeam@chromium.org, rdevlin.cronin@chromium.org

[David Tseng, 2016-12-15 22:43:02]

This was kind of a pain...various issues with the extension system. Noted here
in case anyone needs to do this in the future:
- externs for enums are a lie; the extension system doesn't actually install the
enum key/values anywhere
- prototypes are just ignored except for constructors
- object constructors ignore constructor arguments
- all bets are off if you do anything in the js custom bindings
- the source of truth is not the idl/json, but the bindings stated under
chrome/renderer/resources/extensions/
- optional args that proceed callbacks are flagged as warnings

Finally, would be nice to not check in auto generated code.

[David Tseng, 2016-12-15 23:10:34]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:11:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 00:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:21:06]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Dan Beam, 2016-12-16 01:48:59]

On 2016/12/15 22:43:02, David Tseng wrote:
> This was kind of a pain...various issues with the extension system. Noted here
> in case anyone needs to do this in the future:
> - externs for enums are a lie; the extension system doesn't actually install
the
> enum key/values anywhere

I didn't really get past this point in the list because I don't understand what
you mean here.

In settings, we use various enums in an IDL:
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/settings_pr...

That get turned into enums in our externs JS:
https://cs.chromium.org/chromium/src/third_party/closure_compiler/externs/set...

And are used at runtime:
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/policy/cr...

So I'm confused at to what this point is saying.  Am I thinking of some other,
similar but different concept?

> - prototypes are just ignored except for constructors
> - object constructors ignore constructor arguments
> - all bets are off if you do anything in the js custom bindings
> - the source of truth is not the idl/json, but the bindings stated under
> chrome/renderer/resources/extensions/
> - optional args that proceed callbacks are flagged as warnings
> 
> Finally, would be nice to not check in auto generated code.

[chromium-reviews, 2016-12-16 21:47:33]

dbeam@chromium.org writes:

> On 2016/12/15 22:43:02, David Tseng wrote:
>> This was kind of a pain...various issues with the extension system. Noted  
>> here
>> in case anyone needs to do this in the future:
>> - externs for enums are a lie; the extension system doesn't actually  
>> install
> the
>> enum key/values anywhere
>
> I didn't really get past this point in the list because I don't understand  
> what
> you mean here.
>
> In settings, we use various enums in an IDL:
>
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/settings_pr...
>
> That get turned into enums in our externs JS:
>
https://cs.chromium.org/chromium/src/third_party/closure_compiler/externs/set...
>
> And are used at runtime:
>
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/policy/cr...
>
> So I'm confused at to what this point is saying.  Am I thinking of some  
> other,
> similar but different concept?
>
Confused me as well so I dug and found:
2ba3c88d6
which rdevlin wrote and added this missing feature. chrome.automation
predates that by at least a year so we actually added the custom binding
ourselves. I'll find some burn time to write a script to convert all of
those instances to conform to capped snake casing I guess. But, not for
this cl.

 
>> - prototypes are just ignored except for constructors
>> - object constructors ignore constructor arguments
>> - all bets are off if you do anything in the js custom bindings
>> - the source of truth is not the idl/json, but the bindings stated under
>> chrome/renderer/resources/extensions/
>> - optional args that proceed callbacks are flagged as warnings
>
>> Finally, would be nice to not check in auto generated code.
>
> https://codereview.chromium.org/2584513006/


-- 

http://www.example.com

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.